Athena Decision Service integration #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vredchenko
force-pushed
the
agent_athena_api_integration_draft
branch
from
36e2c16 to
0e4e9cb
Compare
vredchenko
added
the
smartem agent
…ntation This commit enables SmartEM to prepare and log decisions that would be sent to the Athena Decision Service API, without requiring database schema changes or area registration infrastructure. Changes: - Add bulk decision submission support to AthenaClient (record_decisions method) - Add get_athena_session_id helper function (returns dummy UUID for now) - Modify decision submission functions to log instead of POST - Enable decision submission in gridsquare prediction handler - Enable decision submission in foilhole prediction handlers (single and bulk) - Use natural IDs (gridsquare_id, foilhole_id) as Athena area IDs Implementation approach: - No database schema changes required - No area registration (assumes EPU/microscope handles it) - Uses dummy session ID (00000000-0000-0000-0000-000000000000) - Logs decision JSON instead of making HTTP calls This is a draft implementation for testing the decision flow. Future work: - Replace dummy session ID with actual session from database/EPU - Implement Athena mock server for testing - Enable actual HTTP POST calls to Athena - Verify area ID mapping with production Athena instance
vredchenko
force-pushed
the
agent_athena_api_integration_draft
branch
from
0e4e9cb to
f5ce77d
Compare
6 tasks
The Athena Decision Service integration was incorrectly placed in the backend (consumer.py). This violates the separation of concerns: - Backend handles recommendations (ML predictions, SSE routing) - Agent handles instructions (user confirmation, microscope control) Changes: - Remove athena_api imports from consumer.py - Remove athena_client initialization and helper functions - Remove Athena calls from prediction handlers - Delete WIP documentation file Bug fixes retained from original PR: - Fix CurrentQualityPrediction.value assignment (was overwriting object) - Fix session.add_all() for list of predictions (was using add()) Agent-side Athena integration tracked in issue #198.
vredchenko
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Draft implementation enabling SmartEM to log ML prediction decisions for Athena Decision Service API without database schema changes.
Changes
AthenaClientwith bulk decision submission (record_decisionsmethod)get_athena_session_id()helper (returns dummy UUID)handle_gridsquare_model_predictionhandle_foilhole_model_predictionhandle_multi_foilhole_model_predictiongridsquare_id,foilhole_id) as Athena area IDsApproach
00000000-0000-0000-0000-000000000000Next Steps