refactor: use Dockerfile.dev for local image builds#166
Open
vredchenko wants to merge 1 commit intomainfrom
Open
refactor: use Dockerfile.dev for local image builds#166vredchenko wants to merge 1 commit intomainfrom
vredchenko wants to merge 1 commit intomainfrom
Conversation
Update dev-k8s.sh to reference Dockerfile.dev, matching the smartem-decisions rename of the source-based Dockerfile. Part of DiamondLightSource/smartem-decisions#212
vredchenko
added
refactoring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dev-k8s.shto referenceDockerfile.devfor local source-based image buildsContext
The smartem-decisions repo renamed its source-based Dockerfile to
Dockerfile.devas part of the Docker-from-PyPI rework. This companion change ensuresensure_local_image()indev-k8s.shpoints to the renamed file.Companion PR
Related
Part of DiamondLightSource/smartem-decisions#212