chore: eslint 9 support

.github/workflows/tests.yml

@@ -13,15 +13,18 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [12.x, 14.x, 16.x]
+        node-version: [18.x, 20.x]
+        eslint-version: [8.x, 9.x]
 
     steps:
     - uses: actions/checkout@v2
     - name: Use Node.js ${{ matrix.node-version }}
       uses: actions/setup-node@v1
       with:
         node-version: ${{ matrix.node-version }}
-    - run: npm install
+    - name: Install ESLint ${{ matrix.eslint-version }}
+      run: npm install eslint@${{ matrix.eslint-version }}
+    - run: npm install --force
     - run: npm test
       env:
         CI: true

eslint.config.js

@@ -0,0 +1,21 @@
+module.exports = {
+  "plugins": {
+    "react": require("eslint-plugin-react"),
+    "jsx-a11y": require("eslint-plugin-jsx-a11y"),
+    "import": require("eslint-plugin-import")
+  },
+  "rules": {
+    "func-names": 0,
+    "global-require": 0,
+    "prefer-destructuring": 0,
+    "strict": 0,
+    // Include rules from airbnb configuration directly here
+    // Make sure to copy the rules from the airbnb configuration
+  },
+  "languageOptions": {
+    "globals": {
+      // Define global variables here for your files
+      "mocha": true
+    }
+  }
+};

lib/rules/connect-prefer-minimum-two-arguments.js

@@ -1,20 +1,24 @@
 const isReactReduxConnect = require('../isReactReduxConnect');
 
-const report = function (context, node) {
-  context.report({
-    message: 'Connect function should have at least 2 arguments.',
-    node,
-  });
-};
+const create = function (context) {
+  const report = function (node) {
+    context.report({
+      message: 'Connect function should have at least 2 arguments.',
+      node,
+    });
+  };
 
-module.exports = function (context) {
   return {
     CallExpression(node) {
       if (isReactReduxConnect(node)) {
         if (node.arguments.length < 2) {
-          report(context, node);
+          report(node);
         }
       }
     },
   };
 };
+
+module.exports = {
+  create,
+};

lib/rules/connect-prefer-named-arguments.js

@@ -7,28 +7,32 @@ const argumentNames = [
   'options',
 ];
 
-const report = function (context, node, i) {
-  context.report({
-    message: `Connect function argument #${i} should be named ${argumentNames[i]}`,
-    node,
-  });
-};
+const create = function (context) {
+  const report = function (node, i) {
+    context.report({
+      message: `Connect function argument #${i + 1} should be named ${argumentNames[i]}`,
+      node,
+    });
+  };
 
-module.exports = function (context) {
   return {
     CallExpression(node) {
       if (isReactReduxConnect(node)) {
         node.arguments.forEach((argument, i) => {
           if (argument.raw && argument.raw !== 'null') {
-            report(context, node, i);
+            report(node, i);
           } else if (
             !argument.raw
             && argumentNames[i]
             && (!argument.name || argument.name !== argumentNames[i])) {
-            report(context, node, i);
+            report(node, i);
           }
         });
       }
     },
   };
 };
+
+module.exports = {
+  create,
+};

lib/rules/mapDispatchToProps-prefer-parameters-names.js

@@ -20,7 +20,7 @@ const check = function (context, params) {
   });
 };
 
-module.exports = function (context) {
+const create = function (context) {
   return {
     VariableDeclaration(node) {
       node.declarations.forEach((decl) => {
@@ -52,3 +52,7 @@ module.exports = function (context) {
     },
   };
 };
+
+module.exports = {
+  create,
+};

lib/rules/mapDispatchToProps-prefer-shorthand.js

@@ -8,13 +8,16 @@ const report = function (context, node) {
   });
 };
 
-const getParamsString = (params, context) =>
-  params.map(param => context.getSource(param)).join(',');
+const getParamsString = (params, context) => {
+  const sourceCode = context.sourceCode ?? context.getSourceCode();
+  return params.map(param => sourceCode.getText(param)).join(',')
+}
 
 
 const propertyCanUseShortHandButDoesnt = (context, prop, dispatchName) => {
   const propName = prop.key && prop.key.name;
-  const sourceCode = context.getSource(prop.value).replace(/(\r\n|\n|\r|\t| |;)/gm, '');
+  const sourceCodeImpl = context.sourceCode ?? context.getSourceCode();
+  const sourceCode = sourceCodeImpl.getText(prop.value).replace(/(\r\n|\n|\r|\t| |;)/gm, '');
   if (prop.value && prop.value.type === 'ArrowFunctionExpression') {
     const fncDef = prop.value;
     const paramString = getParamsString(fncDef.params, context);
@@ -42,8 +45,7 @@ const checkReturnNode = function (context, returnNode, dispatchName) {
   }
 };
 
-
-module.exports = function (context) {
+const create = function (context) {
   return {
     VariableDeclaration(node) {
       node.declarations.forEach((decl) => {
@@ -84,3 +86,7 @@ module.exports = function (context) {
     },
   };
 };
+
+module.exports = {
+  create,
+};

lib/rules/mapDispatchToProps-returns-object.js

@@ -8,8 +8,7 @@ const report = function (context, node) {
   });
 };
 
-
-module.exports = function (context) {
+const create = function (context) {
   return {
     VariableDeclaration(node) {
       node.declarations.forEach((decl) => {
@@ -50,3 +49,7 @@ module.exports = function (context) {
     },
   };
 };
+
+module.exports = {
+  create,
+};

lib/rules/mapStateToProps-no-store.js

@@ -44,7 +44,7 @@ const checkFunction = function (context, body, firstParamName) {
   }
 };
 
-module.exports = function (context) {
+const create = function (context) {
   return {
     VariableDeclaration(node) {
       node.declarations.forEach((decl) => {
@@ -78,3 +78,7 @@ module.exports = function (context) {
     },
   };
 };
+
+module.exports = {
+  create,
+};

lib/rules/mapStateToProps-prefer-hoisted.js

@@ -29,15 +29,14 @@ const checkProp = (node, context) => {
   }
 };
 
-
 const checkFunction = function (context, body) {
   const returnNode = utils.getReturnNode(body);
   if (returnNode && returnNode.type === 'ObjectExpression') {
     returnNode.properties.forEach(prop => checkProp(prop.value, context));
   }
 };
 
-module.exports = function (context) {
+const create = function (context) {
   return {
     VariableDeclaration(node) {
       node.declarations.forEach((decl) => {
@@ -62,3 +61,7 @@ module.exports = function (context) {
     },
   };
 };
+
+module.exports = {
+  create,
+};

lib/rules/mapStateToProps-prefer-parameters-names.js

@@ -20,7 +20,7 @@ const check = function (context, params) {
   });
 };
 
-module.exports = function (context) {
+const create = function (context) {
   return {
     VariableDeclaration(node) {
       node.declarations.forEach((decl) => {
@@ -52,3 +52,7 @@ module.exports = function (context) {
     },
   };
 };
+
+module.exports = {
+  create,
+};

lib/rules/mapStateToProps-prefer-selectors.js

@@ -62,7 +62,7 @@ const check = function (context, node, matching, validateParams) {
   }
 };
 
-module.exports = function (context) {
+const create = function (context) {
   const config = context.options[0] || {};
   return {
     VariableDeclaration(node) {
@@ -95,3 +95,14 @@ module.exports = function (context) {
     },
   };
 };
+
+module.exports = {
+  create,
+  meta: {
+    schema: {
+      matching: {
+        type: 'string'
+      }
+    }
+  },
+};

lib/rules/no-unused-prop-types.js

@@ -56,14 +56,14 @@ const propsUsedInRedux = function (context) {
   return {
     MemberExpression(node) {
       const nodeName = node.object.name;
-      const usedInReactRedux = context.getAncestors()
+      const usedInReactRedux = context.getSourceCode().getAncestors(node)
         .some(ancestor => belongsToReduxReact(ancestor, nodeName));
       if (usedInReactRedux) {
         context.report(node, `exclude:${node.property.name}`);
       }
     },
     ObjectPattern(node) {
-      const usedInReactRedux = context.getAncestors()
+      const usedInReactRedux = context.getSourceCode().getAncestors(node)
         .some(ancestor => belongsToReduxReact(ancestor, null, node));
       if (usedInReactRedux) {
         node.properties.forEach((prop) => {
@@ -85,4 +85,4 @@ const getPropNameFromReduxRuleMessage = message => message.replace('exclude:', '
 module.exports = filterReports([
   propsUsedInRedux,
   noUnusedPropTypesReact,
-], getPropNameFromReactRuleMessage, getPropNameFromReduxRuleMessage);
+], getPropNameFromReactRuleMessage, getPropNameFromReduxRuleMessage);

lib/rules/prefer-separate-component-file.js

@@ -7,27 +7,30 @@ const report = function (context, node) {
   });
 };
 
-module.exports = function (context) {
-  return {
-    CallExpression(node) {
-      if (isReactReduxConnect(node)) {
-        const component =
-          node.parent &&
-          node.parent.arguments &&
-          node.parent.arguments[0];
-        if (component) {
-          const vars = context.getScope().variables;
-          vars.forEach((definedVar) => {
-            if (component.name === definedVar.name) {
-              definedVar.defs.forEach((def) => {
-                if (!(def.type === 'ImportBinding' || context.getSource(def.node).includes('require'))) {
-                  report(context, component);
-                }
-              });
-            }
-          });
+module.exports = {
+  create(context) {
+    const sourceCode = context.sourceCode ?? context.getSourceCode();
+    return {
+      CallExpression(node) {
+        if (isReactReduxConnect(node)) {
+          const component =
+            node.parent &&
+            node.parent.arguments &&
+            node.parent.arguments[0];
+          if (component) {
+            const vars = sourceCode.getScope(component).variables;
+            vars.forEach((definedVar) => {
+              if (component.name === definedVar.name) {
+                definedVar.defs.forEach((def) => {
+                  if (!(def.type === 'ImportBinding' || sourceCode.getText(def.node).includes('require'))) {
+                    report(context, component);
+                  }
+                });
+              }
+            });
+          }
         }
-      }
-    },
-  };
+      },
+    };
+  },
 };