Add support for APsystem micro-converters using ECU-R#176
Open
rkokkelk wants to merge 231 commits intoDiedB:mainfrom
Open
Add support for APsystem micro-converters using ECU-R#176rkokkelk wants to merge 231 commits intoDiedB:mainfrom
rkokkelk wants to merge 231 commits intoDiedB:mainfrom
Conversation
Owner
|
Are you sure this compiles? The TypeScript compiler seems to find quite a few issues (see 'files changed', TypeScript errors are embedded in there). |
APsystems is not defined in Typescript and therefore does not contain a type specification. In order for TS to compile properly `alltypes.d.ts` is defined to define apsystems module.
Author
|
There were indeed some issues which should now be resolved. Some issues mentioned by
|
Changelog: Deprecate several drivers
Due too unknown reasons, the cronjob timekeeping was not working correclty. Therefore too many request were send to the device which might crash it, forcing a powerreset. To prevent this, code was added to ensure only 1 request is send every minute. Cronjob timekeeping seemed to work again, so old can be removed.
APsystems is not defined in Typescript and therefore does not contain a type specification. In order for TS to compile properly `alltypes.d.ts` is defined to define apsystems module.
…s into apsystems_ecur
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continued PR from #175 . Due to rebase on different branch new PR had to be created. Main difference is that this PR is based on the
sdk-v3branch instead of master.With the discussion based on the separation of responsibility in the
apsystemsmodule. I'm not looking forward to duplicating basically the same code and having to maintain it in two separate locations. I understand your maintainability point of view, how about I give you direct access to the repo so that you can modify it as you see fit. So that the code is not duplicated but you can still modify for maintainability of this app.