Homeview masonary to sections - #247
Merged
Merged
Conversation
DigiLive
force-pushed
the
homeview-masonary-to-sections
branch
from
September 1, 2025 08:13
421de8c to
2de5c16
Compare
Owner
Author
|
Hi @AalianKhan Can you please check this PR for any issues. |
AalianKhan
requested changes
Sep 2, 2025
Rename all references of "chips" to "badges" across documentation to align terminology with the current UI and component model. This clarifies options, examples, and links so users can find and configure badge-related settings (e.g., extra badges, weather badge) without confusion.
DigiLive
marked this pull request as ready for review
October 19, 2025 08:56
Updates view creation to leverage sections for improved layout control, especially on the home view. The home view now uses a grid layout via sections. This change makes it easier to create complex layouts and improves responsiveness. Previously, the card creation logic was embedded directly within each view, leading to code duplication and difficulty in customizing layouts. The changes introduce the concept of sections, which are distinct areas within a view that can contain multiple cards. The home view is updated to use sections for the persons, areas, and quick access cards. This makes it easier to create responsive layouts that adapt to different screen sizes.
This push was meant for debug purposes only.
DigiLive
force-pushed
the
homeview-masonary-to-sections
branch
from
October 19, 2025 09:11
b10913c to
212c04e
Compare
Remove legacy chips card/types and an obsolete notice manager as part of the refactor that migrates chips functionality to the new badges approach. This cleans up redundant type definitions and utility code, reduces maintenance overhead, and prevents stale/deprecated APIs from being used going forward.
Rename the switch confirmation translation key from "chip_confirmation" to "badge_confirmation" and update usages. Aligns translations and code with the chips-to-badges refactor so confirmation messaging uses consistent terminology across locales.
Update the project version to v3.0.0-alpha.1 across package metadata, documentation badges/links, and the runtime version string. Prepares a new alpha release so users and tools reflect the upcoming release candidate and documentation points to the correct tag.
5 tasks
Updated the property name from showControls to show_controls across multiple files for consistency with naming conventions. This change improves code readability and maintainability.
AalianKhan
previously approved these changes
Jan 31, 2026
- Restore default strategy options on import failure. Prevents leaving options undefined after an import error so the application has a valid fallback configuration. - Enforce correct typing when setting undisclosed area id. Ensures type compatibility and avoids type errors when mutating the undisclosed area configuration. - Allow areas map to accept aggregate area configs. Supports using a shorthand/all-areas config alongside individual area entries in the strategy configuration. - Add optional hidden flag to aggregate area config. Enables marking groups of areas as hidden without changing individual area definitions. - Broaden view section return type and fix a comment typo. Reflects that view creation can return either card arrays or sectioned configs and improves source clarity.
- Fix a typo in a comment. Improve clarity by correcting a misspelled word in the inspection comment. - Broaden the return type of the view sections method. Allow returning either a list of cards or a list of sections so views that produce card arrays are supported alongside section-based views.
- Restore strategy options to defaults on import failure. Why: ensures the registry retains a valid configuration when loading strategy options fails, preventing an undefined or partially-initialized state. - Enforce area_id assignment with correct typing for undisclosed area. Why: prevents a typing/assignment issue and guarantees the required property stays set on the undisclosed area so downstream logic can rely on it.
Corrected a minor typo in the comment to improve clarity and maintain code quality. This change ensures that the comment accurately describes the functionality of the method.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 42 out of 44 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Updated comments to reflect the correct method name for creating card configurations in the getView() function. This improves clarity and ensures accurate documentation for future reference.
# Conflicts: # README.md # dist/mushroom-strategy.js # docs/index.md # docs/options/home-view-options.md # package-lock.json # package.json # src/mushroom-strategy.ts # src/views/AbstractView.ts # src/views/HomeView.ts
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 15 out of 16 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Updated the logic for displaying greeting and area cards based on visibility settings. Simplified conditional checks and improved readability by using nullish coalescing. Added a new configuration file for Codacy to enhance code quality checks.
Improved the formatting of various Markdown files to ensure uniformity in bullet points and line breaks. This enhances readability and maintains consistent style across the documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature Pull Request
Thank you for contributing to the project!
Please fill out the following information to help us review your pull request.
Feature Summary
Updates view creation to leverage sections for improved layout control, especially on the home view.
The home view now uses a grid layout via sections.
Motivation and Context
This change makes it easier to create complex layouts and improves responsiveness.
Previously, the card creation logic was embedded directly within each view, leading to code duplication and difficulty in customizing layouts.
The changes introduce the concept of sections, which are distinct areas within a view that can contain multiple cards.
The home view is updated to use sections for the persons, areas, and quick access cards.
This makes it easier to create responsive layouts that adapt to different screen sizes.
List of Changes
Wiki Updates
The documentation still has to be updated to reflect this PR because it includes PR #246.
Also the the Home view looks different now, so images have to be updated.
Agreements
Please confirm the following by inserting an
xbetween the brackets:Depends on #246