Skip to content

[FIX]: Removing the default props (Wrapper props) suppport from the conditional builder #510

Merged
RamSuthar-Digia merged 2 commits intomainfrom
arun/fix-CB
Feb 12, 2026
Merged

[FIX]: Removing the default props (Wrapper props) suppport from the conditional builder #510
RamSuthar-Digia merged 2 commits intomainfrom
arun/fix-CB

Conversation

@carbonFibreCode
Copy link
Collaborator

No description provided.

@coderabbitai
Copy link

coderabbitai bot commented Feb 10, 2026

Walkthrough

The VWConditionalBuilder constructor signature was narrowed by removing super.commonProps and super.refName from its public parameter list, retaining super.parentProps and required super.childGroups. Internal initialization of these properties remains unchanged.

Changes

Cohort / File(s) Summary
VWConditionalBuilder Constructor API
lib/src/framework/widgets/conditional_builder.dart
Removed super.commonProps and super.refName parameters from the public constructor signature while preserving internal initialization of these properties to null. Constructor now accepts only super.parentProps and required super.childGroups.
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive No description was provided by the author, making it impossible to assess relevance to the changeset. Add a description explaining why parent props needed to be exposed in the VWConditionalBuilder constructor API.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title mentions removing default props (Wrapper props) from conditional builder, which aligns with the actual change of removing super.commonProps and super.refName from the public constructor parameters.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch arun/fix-CB

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@carbonFibreCode carbonFibreCode changed the title [FIX]: fixing the parent props [FIX]: Removing the default props (Wrapper props) suppport from the conditional builder Feb 11, 2026
@RamSuthar-Digia RamSuthar-Digia merged commit 747282b into main Feb 12, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants