PR #1 updatesToLanyardLandTheme#1
Open
rgadon107 wants to merge 20 commits intoDigitalCanvas:masterfrom
Open
Conversation
- Return the layout configuration to 'full-width-content' only.
- clear floats on pseudo-elements. - Add flexbox styles to container element.
-Add separate _colors and _typography partial files. - Declare variables for use throughout stylesheet.
- font-family; - font-weight; - font-size; - Declare variables defined in 'variables' directory. Changes can be managed in one location rather than many.
- Includes specialized styling to color bullet points differently than list item elements.
- Set 'list-type-disc' property to 'none'. Prevent display of 2 sets of bullet items on same content when 'ul.color-with-psuedo' in use. - Remove float clearing on .woocommerce selector. Not needed. - Modify list-items partial file. Add right margin between bullet and <li> content. Fix top property to align bullets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This repository is a fork of the 'landyardland-theme' from DigitalCanvas. This PR contains the updates to the modified-genesis-sample child theme ( 'landyardland-theme' ) used to complete the development assignment for Digital Canvas LLC.
Directories and files targeted by this PR:
/config/layouts.php,/config/appearance.php,/lib/functions.php,functions.php,/lib/woocommerce/genesis-sample-woocommerce.css,/sass/variables/_colors.scss,/sass/variables/_typography.scss,/sass/components/_list-items.scss,/sass/_defaults.scss,/sass/_plugins.scss, and/sass/_content.scss.Modifications to the WooCommerce plugin ( Task #2 ) can be viewed in the
extend-woocommerceplugin athttps://github.com/rgadon107/extend-woocommerce. Please look at the file/extend-woocommerce/src/asset/load-assets.phpfor the relevant code that manages the production description template.