Update demo-todo-app.spec.ts (pbi-6.3 - ensure PR auto refresh) by amarilda611 · Pull Request #109 · DigitalProductInnovationAndDevelopment/Code-Reviews-of-GUI-Tests

amarilda611 · 2025-07-13T21:36:28Z

ensuring auto refresh of the action after changing to await test.step('Showing completed items', async ({ page }) => { // Added 'page' parameter here

github-actions · 2025-07-15T14:06:57Z

🔍 GUI Test Review

Checklist

▶️ Playwright

Run	Total	Passed	Failed	Skipped	Pass-rate	Duration
PR	30	30	0	0	100%	15988.719999999998 ms
Main	30	30	0	0	100%	14253.071 ms

🎨 Prettier (PR)

Metric	PR
Files needing format	2
Places to fix	400

Files: tests/demo-todo-app.spec.ts, tests/eslint-config.test.ts

📋 ESLint (PR)

Metric	PR
Errors	0
Warnings	0
Fixable Errors	0
Fixable Warns	0

No ESLint errors

👉 Open full dashboard ↗

Automated comment — updates on every push.

Adding new changes to ensure the auto refresh of the PR.

github-actions · 2025-07-15T14:30:50Z

 test.describe('New Todo', () => {
  test('should allow me to add todo items', async ({ page }) => {


[prettier] _{reported by reviewdog 🐶}

Suggested change

test.describe('New Todo', () => {

test('should allow me to add todo items', async ({ page }) => {

test.describe("New Todo", () => {

test("should allow me to add todo items", async ({ page }) => {

github-actions · 2025-07-15T14:30:50Z

+    // await expect(page).toHaveScreenshot('initial-empty-state.png'); // Capture initial state
+
    // create a new todo locator
    const newTodo = page.getByPlaceholder('What needs to be done?');


[prettier] _{reported by reviewdog 🐶}

Suggested change

const newTodo = page.getByPlaceholder('What needs to be done?');

const newTodo = page.getByPlaceholder("What needs to be done?");

github-actions · 2025-07-15T14:30:50Z

    const todoCount = page.getByTestId('todo-count')
-
+


[prettier] _{reported by reviewdog 🐶}

Suggested change

const todoCount = page.getByTestId('todo-count')

const todoCount = page.getByTestId("todo-count");

github-actions · 2025-07-15T14:30:51Z

@@ -87,6 +93,9 @@ test.describe('Mark all as completed', () => {
    // Ensure all todos have 'completed' class.
    await expect(page.getByTestId('todo-item')).toHaveClass(['completed', 'completed', 'completed']);


[prettier] _{reported by reviewdog 🐶}

Suggested change

await expect(page.getByTestId('todo-item')).toHaveClass(['completed', 'completed', 'completed']);

await expect(page.getByTestId("todo-item")).toHaveClass([

"completed",

"completed",

"completed",

]);

github-actions · 2025-07-15T14:30:51Z

    await checkNumberOfCompletedTodosInLocalStorage(page, 3);
+
+    // ⭐ ADDED THIS LINE HERE ⭐
+    await expect(page).toHaveScreenshot('all-items-completed.png'); // Capture state after marking all as complete


[prettier] _{reported by reviewdog 🐶}

Suggested change

await expect(page).toHaveScreenshot('all-items-completed.png'); // Capture state after marking all as complete

await expect(page).toHaveScreenshot("all-items-completed.png"); // Capture state after marking all as complete

github-actions · 2025-07-15T14:30:51Z

  test('should respect the back button', async ({ page }) => {
-    const todoItem = page.getByTestId('todo-item'); 
+    const todoItem = page.getByTestId('todo-item');
    await page.getByTestId('todo-item').nth(1).getByRole('checkbox').check();


[prettier] _{reported by reviewdog 🐶}

Suggested change

test('should respect the back button', async ({ page }) => {

const todoItem = page.getByTestId('todo-item');

const todoItem = page.getByTestId('todo-item');

await page.getByTestId('todo-item').nth(1).getByRole('checkbox').check();

test("should respect the back button", async ({ page }) => {

const todoItem = page.getByTestId("todo-item");

await page.getByTestId("todo-item").nth(1).getByRole("checkbox").check();

github-actions · 2025-07-15T14:30:51Z

+    await test.step('Showing completed items', async ({ page }) => { // This was the previous change
      await page.getByRole('link', { name: 'Completed' }).click();


[prettier] _{reported by reviewdog 🐶}

Suggested change

await test.step('Showing completed items', async ({ page }) => { // This was the previous change

await page.getByRole('link', { name: 'Completed' }).click();

await test.step("Showing completed items", async ({ page }) => {

// This was the previous change

await page.getByRole("link", { name: "Completed" }).click();

github-actions · 2025-07-15T14:30:51Z

  return await page.waitForFunction(t => {
    return JSON.parse(localStorage['react-todos']).map((todo: any) => todo.title).includes(t);


[prettier] _{reported by reviewdog 🐶}

Suggested change

return await page.waitForFunction(t => {

return JSON.parse(localStorage['react-todos']).map((todo: any) => todo.title).includes(t);

return await page.waitForFunction((t) => {

return JSON.parse(localStorage["react-todos"])

.map((todo: any) => todo.title)

.includes(t);

github-actions · 2025-07-15T14:30:53Z

[prettier] _{reported by reviewdog 🐶}

Code-Reviews-of-GUI-Tests/tests/demo-todo-app.spec.ts

Lines 68 to 70 in 5fcd4f2

await expect(page.getByText('3 items left')).toBeVisible();

await expect(todoCount).toHaveText('3 items left');

await expect(todoCount).toContainText('3');

github-actions · 2025-07-15T14:30:54Z

[prettier] _{reported by reviewdog 🐶}

Code-Reviews-of-GUI-Tests/tests/demo-todo-app.spec.ts

Lines 101 to 102 in 5fcd4f2

test('should allow me to clear the complete state of all items', async ({ page }) => {

const toggleAll = page.getByLabel('Mark all as complete');

github-actions · 2025-07-15T14:30:55Z

[prettier] _{reported by reviewdog 🐶}

Code-Reviews-of-GUI-Tests/tests/demo-todo-app.spec.ts

Lines 373 to 374 in 5fcd4f2

await test.step('Showing active items', async () => {

await page.getByRole('link', { name: 'Active' }).click();

github-actions · 2025-07-15T14:35:48Z

🔍 GUI Test Review

Checklist

▶️ Playwright

Run	Total	Passed	Failed	Skipped	Pass-rate	Duration
PR	0	0	0	0	0%	0 ms
Main	30	30	0	0	100%	14394.272 ms

🎨 Prettier (PR)

Metric	PR
Files needing format	2
Places to fix	403

Files: tests/demo-todo-app.spec.ts, tests/eslint-config.test.ts

📋 ESLint (PR)

Metric	PR
Errors	0
Warnings	0
Fixable Errors	0
Fixable Warns	0

No ESLint errors

👉 Open full dashboard ↗

Automated comment — updates on every push.

Update demo-todo-app.spec.ts

12c3776

amarilda611 had a problem deploying to github-pages July 13, 2025 21:39 — with GitHub Actions Failure

amarilda611 temporarily deployed to github-pages July 15, 2025 14:01 — with GitHub Pages Inactive

Update demo-todo-app.spec.ts

a3b8722

amarilda611 temporarily deployed to github-pages July 15, 2025 14:03 — with GitHub Pages Inactive

amarilda611 temporarily deployed to github-pages July 15, 2025 14:06 — with GitHub Actions Inactive

amarilda611 changed the title ~~Update demo-todo-app.spec.ts~~ Update demo-todo-app.spec.ts (Ensure PR autorefresh) Jul 15, 2025

amarilda611 changed the title ~~Update demo-todo-app.spec.ts (Ensure PR autorefresh)~~ Update demo-todo-app.spec.ts (Ensure PR auto refresh) Jul 15, 2025

Update demo-todo-app.spec.ts

5fcd4f2

Adding new changes to ensure the auto refresh of the PR.

github-actions Bot reviewed Jul 15, 2025

View reviewed changes

amarilda611 temporarily deployed to github-pages July 15, 2025 14:30 — with GitHub Pages Inactive

amarilda611 temporarily deployed to github-pages July 15, 2025 14:34 — with GitHub Actions Inactive

amarilda611 changed the title ~~Update demo-todo-app.spec.ts (Ensure PR auto refresh)~~ pbi-6.3 update demo-todo-app.spec.ts (Ensure PR auto refresh) Jul 15, 2025

amarilda611 changed the title ~~pbi-6.3 update demo-todo-app.spec.ts (Ensure PR auto refresh)~~ Update demo-todo-app.spec.ts (pbi-6.3 - ensure PR auto refresh) Jul 15, 2025

		test.describe('New Todo', () => {
		test('should allow me to add todo items', async ({ page }) => {

	const newTodo = page.getByPlaceholder('What needs to be done?');
	const newTodo = page.getByPlaceholder("What needs to be done?");

	const todoCount = page.getByTestId('todo-count')


	const todoCount = page.getByTestId("todo-count");

		@@ -87,6 +93,9 @@ test.describe('Mark all as completed', () => {
		// Ensure all todos have 'completed' class.
		await expect(page.getByTestId('todo-item')).toHaveClass(['completed', 'completed', 'completed']);

-    await expect(page.getByTestId('todo-item')).toHaveClass(['completed', 'completed', 'completed']);
+    await expect(page.getByTestId("todo-item")).toHaveClass([
+      "completed",
+      "completed",
+      "completed",
+    ]);

	await expect(page).toHaveScreenshot('all-items-completed.png'); // Capture state after marking all as complete
	await expect(page).toHaveScreenshot("all-items-completed.png"); // Capture state after marking all as complete

		await test.step('Showing completed items', async ({ page }) => { // This was the previous change
		await page.getByRole('link', { name: 'Completed' }).click();

		return await page.waitForFunction(t => {
		return JSON.parse(localStorage['react-todos']).map((todo: any) => todo.title).includes(t);

	await expect(page.getByText('3 items left')).toBeVisible();
	await expect(todoCount).toHaveText('3 items left');
	await expect(todoCount).toContainText('3');

	test('should allow me to clear the complete state of all items', async ({ page }) => {
	const toggleAll = page.getByLabel('Mark all as complete');

	await test.step('Showing active items', async () => {
	await page.getByRole('link', { name: 'Active' }).click();

Conversation

amarilda611 commented Jul 13, 2025

Uh oh!

github-actions Bot commented Jul 15, 2025

🔍 GUI Test Review

▶️ Playwright

🎨 Prettier (PR)

📋 ESLint (PR)

Uh oh!

github-actions Bot Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 15, 2025

🔍 GUI Test Review

▶️ Playwright

🎨 Prettier (PR)

📋 ESLint (PR)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant