Conversation
Line 9 -capture a screenshot of the entire page at its initial state
changes line 5 - to make sure the PR build for pbi-2.2 targeting main line 37- v4 is the latest stable version and generally recommended for security and feature updates. added 21-30 ensure that visual regression tests run on a feature branch (like pbi-2.2) compare against the baseline screenshots from the main branch, rather than potentially outdated baselines present in the feature branch itself. added 46-47 changes on 64-69 changes from line 95
|
👋 Hello! Here's the link to our GitHub Pages site: This link will always show the latest version from our main branch. |
|
👋 Hello! Here's the link to our GitHub Pages site: This link will always show the latest version from our main branch. |
Corrected Playwright snapshot base path: Updated paths from tests/__snapshots__/ to the actual tests/demo-todo-app.spec.ts-snapshots/ in both the baseline fetching step and the artifact upload step. This ensures Playwright correctly finds and uses the generated visual baselines. Removed redundant "Capture initial page screenshot" step: This specific test execution step was removed as the main npx playwright test command already runs all tests, including visual ones, making the separate step unnecessary. Enhanced Pull Request comment: The PR comment now provides clearer instructions for reviewers on how to access and interpret the visual regression report by guiding them to download the playwright-visual-comparison-report artifact and open the playwright-report/index.html file.
|
👋 Hello! Here's the link to our GitHub Pages site: This link will always show the latest version from our main branch. |
|
👋 Hello! Here's the link to our GitHub Pages site: This link will always show the latest version from our main branch. |
|
👋 Hello! Here's the link to our GitHub Pages site: This link will always show the latest version from our main branch. |
|
👋 Hello! Here's the link to our GitHub Pages site: This link will always show the latest version from our main branch. |
1 similar comment
|
👋 Hello! Here's the link to our GitHub Pages site: This link will always show the latest version from our main branch. |
1 participant
Changed the playwright file and added await expect(locator).toHaveScreenshot() in test file. Purpose to see screenshots from main branch test and pbi-2.2 branch test.
Applied the commands in bash:
npx playwright test --update-snapshots
git add tests/demo-todo-app.spec.ts-snapshots/
git commit -m "feat(playwright): Add generated baseline snapshots for visual regression"
git push origin main
git pull origin main