Skip to content
This repository was archived by the owner on Apr 29, 2025. It is now read-only.

Add area type icon, disable hover effect#14

Open
NingyueZhou wants to merge 12 commits intomainfrom
page/refa-area-add-type-icon
Open

Add area type icon, disable hover effect#14
NingyueZhou wants to merge 12 commits intomainfrom
page/refa-area-add-type-icon

Conversation

@NingyueZhou
Copy link
Copy Markdown
Contributor

@NingyueZhou NingyueZhou commented Aug 8, 2024

Area type - Software Engineering:
image

Area type - Security-related Software Engineering:
image

Known issue: if hover over an area card, I changed opacity to 10, therefore the tooltip and the info, assess icons are not really visible anymore. Maybe open another PR to fix the hover logic (maybe hover opacity to 0, keep the info and assess icons visible, and add area type icon legend somewhere)?
image

@NingyueZhou NingyueZhou self-assigned this Aug 8, 2024
@NingyueZhou NingyueZhou marked this pull request as ready for review August 9, 2024 10:33
@mourabitiziyad
Copy link
Copy Markdown
Contributor

We should disable the hover effect completely.

The three buttons on the top right should always remain visible so that once the user clicks the eye to see the artefacts they can still see the icons.

@NingyueZhou
Copy link
Copy Markdown
Contributor Author

NingyueZhou commented Aug 9, 2024

We should disable the hover effect completely.

The three buttons on the top right should always remain visible so that once the user clicks the eye to see the artefacts they can still see the icons.

So disable the hover effect, and keep three icons always visible, only clicking on the eye icon will show the artifacts underneath? I can try to do it in this pr

@mourabitiziyad
Copy link
Copy Markdown
Contributor

We should disable the hover effect completely.

The three buttons on the top right should always remain visible so that once the user clicks the eye to see the artefacts they can still see the icons.

So disable the hover effect, and keep three icons always visible, only clicking on the eye icon will show the artifacts underneath? I can try to do it in this pr

Yes. Pretty much

@NingyueZhou NingyueZhou changed the title Add area type icon Add area type icon, disable hover effect Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants