Skip to content
This repository was archived by the owner on Oct 22, 2025. It is now read-only.

Improve Plugin #7

Draft
Findus23 wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Improve Plugin #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5fc3aae
minor changes in controller
Findus23 Nov 18, 2021
5142e6e
use DataTables for everything
Findus23 Nov 18, 2021
0bca2bd
remove commented out function
Findus23 Nov 18, 2021
9334b29
improve style of perfchecks
Findus23 Nov 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
154 changes: 60 additions & 94 deletions API.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,35 +35,26 @@ class API extends \Piwik\Plugin\API
* @return DataTable
*/
function getProblematicSegments() {
if (!Piwik::hasUserSuperUserAccess()) {
throw new \Exception("No access to DBHealth");
Piwik::checkUserHasAdminAccess($initialIdSite);
}
try {
$dataTable = new DataTable();

$query = "SELECT name,idsegment,definition,login,enable_only_idsite,ts_created,ts_last_edit FROM `matomo_segment` where definition like '%@%' and deleted not like '1' ";
$result = $this->getDb()->fetchAssoc($query);

foreach ($result as $item) {
$dataTable->addRowsFromSimpleArray(array(
array('Name' => $item['name'],
'Idsegment' => $item['idsegment'],
'Definition' => $item['definition'],
'Used on siteId (0=all)' => $item['enable_only_idsite'],
'Created by' => $item['login'],
'Creation date' => $item['ts_created'],
'Last updated' => $item['ts_last_edit']
)
));

}
return $dataTable;

} catch (\Exception $e) {
return $e->getMessage();
}
Piwik::checkUserHasSuperUserAccess();
$dataTable = new DataTable();

$query = "SELECT name,idsegment,definition,login,enable_only_idsite,ts_created,ts_last_edit FROM `matomo_segment` where definition like '%@%' and deleted not like '1' ";
$result = $this->getDb()->fetchAssoc($query);

foreach ($result as $item) {
$dataTable->addRowsFromSimpleArray(array(
array('Name' => $item['name'],
'Idsegment' => $item['idsegment'],
'Definition' => $item['definition'],
'Used on siteId (0=all)' => $item['enable_only_idsite'],
'Created by' => $item['login'],
'Creation date' => $item['ts_created'],
'Last updated' => $item['ts_last_edit']
)
));

}
return $dataTable;
}


Expand All @@ -75,28 +66,20 @@ function getProblematicSegments() {
*/
function getMysqlStatusData()
{
if (!Piwik::hasUserSuperUserAccess()) {
throw new \Exception("No access to DBHealth");
Piwik::checkUserHasAdminAccess($initialIdSite);
}

try {
$dataTable = new DataTable();

$query = "SHOW STATUS";
$result = $this->getDb()->fetchAssoc($query);
Piwik::checkUserHasSuperUserAccess();
$dataTable = new DataTable();

foreach ($result as $item) {
$dataTable->addRowsFromSimpleArray(array(
array('Name' => $item['Variable_name'], 'Value' => $item['Value'])
));
$query = "SHOW STATUS";
$result = $this->getDb()->fetchAssoc($query);

}
return $dataTable;
foreach ($result as $item) {
$dataTable->addRowsFromSimpleArray(array(
array('Name' => $item['Variable_name'], 'Value' => $item['Value'])
));

} catch (\Exception $e) {
return $e->getMessage();
}
return $dataTable;


}

Expand All @@ -106,37 +89,29 @@ function getMysqlStatusData()
* @return DataTable
*/
function getMysqlTableStatus() {
if (!Piwik::hasUserSuperUserAccess()) {
throw new \Exception("No access to DBHealth");
Piwik::checkUserHasAdminAccess($initialIdSite);
}
try {
$dataTable = new DataTable();

$query = "SHOW TABLE STATUS";
$result = $this->getDb()->fetchAssoc($query);

foreach ($result as $item) {
$dataTable->addRowsFromSimpleArray(array(
array('Name' => $item['Name'],
'Collation' => $item['Collation'],
'Engine' => $item['Engine'],
'Rows' => $item['Rows'],
'Avg_row_length' => $item['Avg_row_length'],
'Data_length' => $item['Data_length'],
'Max_data_length' => $item['Max_data_length'],
'Index_length' => $item['Index_length'],
'Data_free' => $item['Data_free'],
'Checksum' => $item['Checksum']
)
));

}
return $dataTable;

} catch (\Exception $e) {
return $e->getMessage();
Piwik::checkUserHasSuperUserAccess();
$dataTable = new DataTable();

$query = "SHOW TABLE STATUS";
$result = $this->getDb()->fetchAssoc($query);

foreach ($result as $item) {
$dataTable->addRowsFromSimpleArray(array(
array('Name' => $item['Name'],
'Collation' => $item['Collation'],
'Engine' => $item['Engine'],
'Rows' => $item['Rows'],
'Avg_row_length' => $item['Avg_row_length'],
'Data_length' => $item['Data_length'],
'Max_data_length' => $item['Max_data_length'],
'Index_length' => $item['Index_length'],
'Data_free' => $item['Data_free'],
'Checksum' => $item['Checksum']
)
));
}
return $dataTable;


}
/**
Expand All @@ -146,28 +121,19 @@ function getMysqlTableStatus() {
*/
function getMysqlVariableData()
{
if (!Piwik::hasUserSuperUserAccess()) {
throw new \Exception("No access to DBHealth");
Piwik::checkUserHasAdminAccess($initialIdSite);
}
try {
$dataTable = new DataTable();

$query = "SHOW VARIABLES";
$result = $this->getDb()->fetchAssoc($query);
Piwik::checkUserHasSuperUserAccess();
$dataTable = new DataTable();

foreach ($result as $item) {
$dataTable->addRowsFromSimpleArray(array(
array('Name' => $item['Variable_name'], 'Value' => $item['Value'])
));
$query = "SHOW VARIABLES";
$result = $this->getDb()->fetchAssoc($query);

}
return $dataTable;
foreach ($result as $item) {
$dataTable->addRowsFromSimpleArray(array(
array('Name' => $item['Variable_name'], 'Value' => $item['Value'])
));

} catch (\Exception $e) {
return $e->getMessage();
}

return $dataTable;
}


Expand Down
Loading