add missing translation, fix edit page

Controller.php

@@ -156,13 +156,11 @@ public function editNotification($id = null)
     {
         Piwik::checkUserHasSuperUserAccess();
         if (!isset($id)) {
-            $notificationId = trim(Request::fromRequest()->getStringParameter('notificationId', 'string'));
-        } else {
-            $notificationId = $id;
+            $id = trim(Request::fromRequest()->getStringParameter('id', 'string'));
         }
 
         $db = Db::get();
-        $notification = $db->fetchRow("SELECT * FROM `" . Common::prefixTable('rebel_notifications') . "` WHERE id = ?", [$notificationId]);
+        $notification = $db->fetchRow("SELECT * FROM `" . Common::prefixTable('rebel_notifications') . "` WHERE id = ?", [$id]);
         if (empty($notification)) {
             throw new \Exception('Notification not found');
         }

Menu.php

@@ -43,7 +43,7 @@ public function configureAdminMenu(MenuAdmin $menu)
             );
             $menu->addItem(
                 'RebelNotifications_RebelNotifications',
-                'RebelNotifications_RebelNotifications',
+                'RebelNotifications_Manage',
                 $this->urlForAction('index'),
                 $order = 43
             );

README.md

@@ -27,6 +27,17 @@ Rebel Notifications are using the built in Notifications in Matomo and adds a UI
 
 This plugin was inspired by the [Admin Notification](https://plugins.matomo.org/AdminNotification) plugin by [Josh Brule](https://github.com/jbrule).
 
+## Installation
+
+Install the plugin as you normally install any Matomo plugin.
+
+## Usage
+
+After installation, a new menu item is visible in the admin part of Matomo - "Rebel Notifications".
+At "Manage" you can add, edit and delete notifications.
+
+When you add or change a notification, nothing is changed until you logout and login. The triggering event for the notifications is `Login.authenticate.successful` - which means that nothing updates until you login.
+
 ## Using RebelNotifications with Matomo API
 
 Examples with curl.

lang/en.json

@@ -0,0 +1,6 @@
+{
+  "RebelNotifications": {
+      "RebelNotifications": "Rebel Notifications",
+      "Manage": "Manage"
+  }
+}

plugin.json

@@ -1,7 +1,7 @@
 {
     "name": "RebelNotifications",
     "description": "Show Notifications to your users.",
-    "version": "5.0.1",
+    "version": "5.0.2",
     "theme": false,
     "require": {
         "matomo": ">=5.0.0-stable,<6.0.0-b1"

templates/editNotification.twig

@@ -26,7 +26,7 @@
                     <div class="row">
                         <label>
                             Message:
-                            <textarea name="message" required>{{ notification.message }}</textarea>
+                            <textarea name="message" class="materialize-textarea" required>{{ notification.message }}</textarea>
                         </label>
                     </div>
                     <div class="row">

templates/manageNotifications.twig

@@ -52,7 +52,7 @@
                             <td>{{ notification.type }}</td>
                             <td>{{ notification.raw }}</td>
                             <td>
-                                <a href="{{ linkTo({'module':'RebelNotifications','action':'editNotification', 'notificationId': notification.id}) }}">
+                                <a href="{{ linkTo({'module':'RebelNotifications','action':'editNotification', 'id': notification.id}) }}">
                                     <span class="icon-edit"></span>
                                 </a>
                             </td>