Skip to content

Comments

Use pnpm catalog#249

Merged
Luca Schneider (Mad-Kat) merged 4 commits intomainfrom
use-pnpm-catalog
Jan 7, 2025
Merged

Use pnpm catalog#249
Luca Schneider (Mad-Kat) merged 4 commits intomainfrom
use-pnpm-catalog

Conversation

@Mad-Kat
Copy link
Collaborator

With version 9.5.0, pnpm added the ability to specify the versions of all packages centrally. I've run the codemod and changed the minimum version to 9.7.0, as they added the ability to manage package manger versions that we already specify in our root package.json.

@changeset-bot
Copy link

changeset-bot bot commented Dec 29, 2024

🦋 Changeset detected

Latest commit: 4eb5202

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 29, 2024

CodSpeed Performance Report

Merging #249 will not alter performance

Comparing use-pnpm-catalog (4eb5202) with main (e14d265)

Summary

✅ 2 untouched benchmarks

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my machine

Copy link
Collaborator

@jantimon Jan Nicklas (jantimon) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a way to prevent npm publish otherwise dependencies: { "yak-swc": "catalog:" } would be published to npm and break on install

Also we might consider splitting the catalog into our core dependencies (which will change the behaviour once we publish to npm) and a dev dependency catalog (which includes docs, vitest, ...)

@Mad-Kat Luca Schneider (Mad-Kat) merged commit 10adce8 into main Jan 7, 2025
8 checks passed
@Mad-Kat Luca Schneider (Mad-Kat) deleted the use-pnpm-catalog branch January 7, 2025 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants