Skip to content

Comments

Fix reference error when only using atoms#383

Merged
Luca Schneider (Mad-Kat) merged 3 commits intomainfrom
fix/only-atoms-import
Jul 11, 2025
Merged

Fix reference error when only using atoms#383
Luca Schneider (Mad-Kat) merged 3 commits intomainfrom
fix/only-atoms-import

Conversation

@Mad-Kat
Copy link
Collaborator

@Mad-Kat Luca Schneider (Mad-Kat) commented Jul 11, 2025

This fixes the issue ReferenceError: __yak_mergeCssProp is not defined when using atoms without any other CSS we provide (css or styled).

We now add the import to our internals when using any yak import, instead of only adding it when a CSS extraction is needed.

@changeset-bot
Copy link

changeset-bot bot commented Jul 11, 2025

🦋 Changeset detected

Latest commit: 3424220

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
yak-swc Patch
next-yak Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2025

🧪 Example App Preview Deployed!

A preview of the example app changes in this PR has been deployed to Vercel:

🔗 View Example App Preview

This preview will update automatically with new commits to this PR.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2025

📚 Documentation Preview Deployed!

A preview of the documentation changes in this PR has been deployed to Vercel:

🔗 View Documentation Preview

This preview will update automatically with new commits to this PR.

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 11, 2025

CodSpeed Performance Report

Merging #383 will degrade performances by 14.75%

Comparing fix/only-atoms-import (3424220) with main (0579320)

Summary

⚡ 2 improvements
❌ 1 (👁 1) regressions
✅ 9 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
render AttrsComponentsStyled 45.1 ms 40.9 ms +10.33%
render DynamicPropsComponentsYak 88.2 ms 78.6 ms +12.17%
👁 render NestedComponentsStyled 11.7 ms 13.7 ms -14.75%

@Mad-Kat Luca Schneider (Mad-Kat) marked this pull request as ready for review July 11, 2025 06:39
@Mad-Kat Luca Schneider (Mad-Kat) merged commit 460a5da into main Jul 11, 2025
8 checks passed
@Mad-Kat Luca Schneider (Mad-Kat) deleted the fix/only-atoms-import branch July 11, 2025 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants