Solution #2523 - Mridul/Edited - 07/06/2025#22
Open
mrid88 wants to merge 2 commits intoDijkstra-Edu:masterfrom
Open
Solution #2523 - Mridul/Edited - 07/06/2025#22mrid88 wants to merge 2 commits intoDijkstra-Edu:masterfrom
mrid88 wants to merge 2 commits intoDijkstra-Edu:masterfrom
Conversation
JRS296
requested changes
Mar 21, 2025
Member
JRS296
left a comment
JRS296
left a comment
There was a problem hiding this comment.
Kindly make the changes requested!
Comment on lines
+1
to
+34
| private static boolean[] isPrime = new boolean[1000001]; This boolean array is used to mark prime numbers up to 1000000. The size of the array is 1000001 to include the number 1000000. | ||
|
|
||
| Static Block: | ||
| The static block is used to initialize the isPrime array and precompute the prime numbers. | ||
|
|
||
| Arrays.fill(isPrime, true); This method sets all elements of the isPrime array to true, assuming all numbers are prime initially. | ||
|
|
||
| precompute(); This method is called to mark non-prime numbers in the isPrime array. | ||
|
|
||
| Method: precompute() | ||
| This method uses the Sieve of Eratosthenes algorithm to mark non-prime numbers in the isPrime array. | ||
|
|
||
| isPrime[0] = isPrime[1] = false; Numbers 0 and 1 are not prime. | ||
|
|
||
| A loop is used to iterate from 2 to sqrt(1000000). | ||
|
|
||
| If isPrime[i] is true, all multiples of i are marked as false (not prime) starting from i*i. | ||
|
|
||
| Method: closestPrimes(int left, int right) | ||
| This method finds the closest prime numbers within the range [left, right]. | ||
|
|
||
| int prev = -1, minDiff = Integer.MAX_VALUE; Variables to track the previous prime number and the minimum difference between consecutive primes. | ||
|
|
||
| int num1 = -1, num2 = -1; Variables to store the closest prime numbers. | ||
|
|
||
| A loop iterates through the range [left, right]. | ||
|
|
||
| If isPrime[i] is true, the number i is a prime. | ||
|
|
||
| If prev is not -1 and the difference (i - prev) is less than minDiff, update minDiff and set num1 to prev and num2 to i. | ||
|
|
||
| Update prev to i. | ||
|
|
||
| If no prime numbers are found, return new int[]{-1, -1}. Otherwise, return the closest prime numbers num1 and num2. No newline at end of file |
Member
There was a problem hiding this comment.
This can be improved quite a bit! Use Markdown, and explain the time and space complexity as well!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added solution.java and explanation.md file