Add ConvertUBOToPushConstantsTestVk.cpp #745
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+154
to
+168
| # Add SPIRV-Tools include directories if needed for SPIRVTools.hpp | ||
| # Test files that include SPIRVTools.hpp need access to spirv-tools headers | ||
| # SPIRVTools.hpp includes "spirv-tools/libspirv.h", so we need the include directory | ||
| if (TARGET SPIRV-Tools-opt) | ||
| get_target_property(SPIRV_TOOLS_SOURCE_DIR SPIRV-Tools-opt SOURCE_DIR) | ||
| get_target_property(SPIRV_TOOLS_BINARY_DIR SPIRV-Tools-opt BINARY_DIR) | ||
| get_filename_component(SPIRV_TOOLS_ROOT_DIR "${SPIRV_TOOLS_SOURCE_DIR}/../.." ABSOLUTE) | ||
| get_filename_component(SPIRV_TOOLS_ROOT_BINARY_DIR "${SPIRV_TOOLS_BINARY_DIR}/../.." ABSOLUTE) | ||
| # Add include subdirectory for public headers like spirv-tools/libspirv.h | ||
| target_include_directories(DiligentCoreAPITest PRIVATE | ||
| ${SPIRV_TOOLS_ROOT_DIR}/include | ||
| ${SPIRV_TOOLS_ROOT_DIR} | ||
| ${SPIRV_TOOLS_ROOT_BINARY_DIR} | ||
| ) | ||
| endif() |
Contributor
There was a problem hiding this comment.
This is annoying.
I pushed a change that removes dependency on libspirv.h, so SPIRVTools.hpp can be included without issues.
Contributor
TheMostDiligent
left a comment
TheMostDiligent
left a comment
There was a problem hiding this comment.
Boy is Vulkan verbose
Comment on lines
+141
to
+146
| void main() | ||
| { | ||
| // Access deeply nested member to generate multiple OpAccessChain instructions | ||
| // This tests PropagateStorageClass with multiple levels of pointer indirection | ||
| out_Color = vec4(in_Color, 1.0) * cb.Data.Nested.Inner.Factor; | ||
| } |
Contributor
There was a problem hiding this comment.
I suggest making the use of push constants a bit more sophisticated: at a minimum, read colors from push constants instead of getting them from the VS.
Maybe also pass structs to a function.
Comment on lines
+289
to
+298
| GLSLangUtils::SpirvVersion Version = GLSLangUtils::SpirvVersion::Vk100; | ||
| if (ShaderType == SHADER_TYPE_RAY_GEN || | ||
| ShaderType == SHADER_TYPE_RAY_MISS || | ||
| ShaderType == SHADER_TYPE_RAY_CLOSEST_HIT || | ||
| ShaderType == SHADER_TYPE_RAY_ANY_HIT || | ||
| ShaderType == SHADER_TYPE_RAY_INTERSECTION || | ||
| ShaderType == SHADER_TYPE_CALLABLE) | ||
| { | ||
| Version = GLSLangUtils::SpirvVersion::Vk110_Spirv14; | ||
| } |
Contributor
There was a problem hiding this comment.
We are not planning to test ray tracing here, so this is not needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.