ConvertUBOToPushConstantsTestVk based on #745 #746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…um, read colors from push constants instead of getting them from the VS. Also pass structs to a function.
… defined or "DILIGENT_USE_SPIRV_TOOLCHAIN" not defined.
…' set but not used [-Werror,-Wunused-but-set-variable]
…n failed in CheckDynamicType(), file DebugUtilities.hpp, line 63: Dynamic type cast failed. Src typeid: 'N8Diligent7Testing20TestingEnvironmentGLE' Dst typeid: 'N8Diligent7Testing20TestingEnvironmentVkE'
- Do not create VkImages that can be obtained from Diligent - Use different background color for each test - Code cleanup
TheMostDiligent
merged commit c0d3ccb
into
DiligentGraphics:inline_constants
37 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetVertexColor