Skip to content

Inline constants small fix #748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheMostDiligent merged 2 commits into from
Jan 1, 2026
Merged

Inline constants small fix #748

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3568b4
small fix
hzqst Jan 1, 2026
fc31467
small fix
hzqst Jan 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Graphics/GraphicsEngine/interface/Constants.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,9 @@ DILIGENT_BEGIN_NAMESPACE(Diligent)
/// Bit shift for the the shading X-axis rate.
#define DILIGENT_SHADING_RATE_X_SHIFT 2

/// Ineline constants data storage (max size is typically 128-256 bytes, use 256 for safety)
#define DILIGENT_MAX_INLINE_CONSTANTS_SIZE 256

static DILIGENT_CONSTEXPR Uint32 MAX_BUFFER_SLOTS = DILIGENT_MAX_BUFFER_SLOTS;
static DILIGENT_CONSTEXPR Uint32 MAX_RENDER_TARGETS = DILIGENT_MAX_RENDER_TARGETS;
static DILIGENT_CONSTEXPR Uint32 MAX_VIEWPORTS = DILIGENT_MAX_VIEWPORTS;
Expand Down
12 changes: 12 additions & 0 deletions Graphics/GraphicsEngineVulkan/include/VulkanUtilities/CommandBuffer.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,6 +504,18 @@ class CommandBuffer
vkCmdBindDescriptorSets(m_VkCmdBuffer, pipelineBindPoint, layout, firstSet, descriptorSetCount, pDescriptorSets, dynamicOffsetCount, pDynamicOffsets);
}

__forceinline void PushConstants(VkPipelineLayout layout,
VkShaderStageFlags stageFlags,
uint32_t offset,
uint32_t size,
const void* pValues)
{
VERIFY_EXPR(m_VkCmdBuffer != VK_NULL_HANDLE);
VERIFY_EXPR(pValues != nullptr);
VERIFY_EXPR(size > 0);
vkCmdPushConstants(m_VkCmdBuffer, layout, stageFlags, offset, size, pValues);
}

__forceinline void CopyBuffer(VkBuffer srcBuffer,
VkBuffer dstBuffer,
uint32_t regionCount,
Expand Down
Loading