Fix issues from https://github.com/DiligentGraphics/DiligentCore/pull/747 #749
Conversation
…URCE_FLAG_INLINE_CONSTANTS flag (DiligentGraphics#672)
…hen remapping resources (DiligentGraphics#672)
- Improve const-correctness - Use unordered_set for seen - Use references instead of non-null pointers
…e reordered (DiligentGraphics#743) The pointer type instruction needs to be reordered, or the SPIRV might be rejected by Vulkan validation layer due to violating SPIR-V rules.
…g opcodes Log a warning and stop propagating on this path
It may become stale after analyses invalidation
…tly handle inline constants
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| void PipelineLayoutVk::Create(RenderDeviceVkImpl* pDeviceVk, RefCntAutoPtr<PipelineResourceSignatureVkImpl> ppSignatures[], Uint32 SignatureCount) noexcept(false) | ||
| void PipelineLayoutVk::Create(RenderDeviceVkImpl* pDeviceVk, |
Check notice
Code scanning / CodeQL
No raw arrays in interfaces Note
| ResCI.Name = pShader->GetDesc().Name; | ||
| ResCI.CombinedSamplerSuffix = pShader->GetDesc().UseCombinedTextureSamplers ? pShader->GetDesc().CombinedSamplerSuffix : nullptr; | ||
| ResCI.LoadShaderStageInputs = pShader->GetDesc().ShaderType == SHADER_TYPE_VERTEX; | ||
| ResCI.LoadUniformBufferReflection = true; //LoadConstantBufferReflection; |
Check notice
Code scanning / CodeQL
Commented-out code Note
| if (ResDesc.Flags & PIPELINE_RESOURCE_FLAG_INLINE_CONSTANTS) | ||
| { | ||
| if (!DstResourceCache.CopyResource<D3D11_RESOURCE_RANGE_CBV>(SrcResourceCache, ResAttr.BindPoints + ArrInd)) | ||
| VERIFY(ResDesc.Flags == PIPELINE_RESOURCE_FLAG_INLINE_CONSTANTS, "INLINE_CONSTANTS flag is not compatible with other flags"); |
Check warning
Code scanning / PREfast
Use 'bitwise and' to check if a flag is set. Warning
| Uint32 ArraySize = Attribs.BindCount; | ||
| if (ResFlags & PIPELINE_RESOURCE_FLAG_INLINE_CONSTANTS) | ||
| { | ||
| VERIFY(ResFlags == PIPELINE_RESOURCE_FLAG_INLINE_CONSTANTS, "INLINE_CONSTANTS flag cannot be combined with other flags."); |
Check warning
Code scanning / PREfast
Use 'bitwise and' to check if a flag is set. Warning
| Uint32 ArraySize = Attribs.BindCount; | ||
| if (ResFlags & PIPELINE_RESOURCE_FLAG_INLINE_CONSTANTS) | ||
| { | ||
| VERIFY(ResFlags == PIPELINE_RESOURCE_FLAG_INLINE_CONSTANTS, "INLINE_CONSTANTS flag cannot be combined with other flags."); |
Check warning
Code scanning / PREfast
Use 'bitwise and' to check if a flag is set. Warning
| Uint32 ArraySize = Attribs.ArraySize; | ||
| if (Flags & PIPELINE_RESOURCE_FLAG_INLINE_CONSTANTS) | ||
| { | ||
| VERIFY(Flags == PIPELINE_RESOURCE_FLAG_INLINE_CONSTANTS, "INLINE_CONSTANTS flag cannot be combined with other flags."); |
Check warning
Code scanning / PREfast
Use 'bitwise and' to check if a flag is set. Warning
2 participants
No description provided.