Test repositories

[MohitMandalia]

Tests

• AccountRepository
• ApplicationRepository
• LocalFilterRepository
• SearchHistoryRepositor

[Tlaster]

Thanks for the PR and for putting time into adding tests.

At the moment I’m going to close/reject this change. In Flare, the vast majority of presenters depend on these repositories, and to make presenter testing practical I’ll need to refactor/adjust these repositories later (APIs, injection boundaries, test fakes, and behaviors). Because of that, the tests in this PR are very likely to become outdated or need a major rewrite, and they don’t match the requirements we need for upcoming presenter-focused testing.

I’d prefer to revisit repository tests after the repository changes are done, or as part of the presenter testing work itself.

[MohitMandalia]

No worries @Tlaster I would like to help you in this project can you guide me on where do you need help so that this project can progress faster.

[Tlaster]

No worries @Tlaster I would like to help you in this project can you guide me on where do you need help so that this project can progress faster.

Thanks for following up!

Regarding repository testing: I’m still thinking through what the best testing strategy should be. Flare went through a lot of rapid iteration early on, and testing wasn’t fully considered in the original design. Some parts ended up being fairly ad-hoc (e.g. parts of AccountRepository.kt), so adding proper tests now requires extra refactoring work first. And since these repositories are foundational (most presenters depend on them), any changes there need to be done very carefully.

As for project progress, things are already moving forward steadily according to the plan. For the next major milestone, iOS is expected to go live on the App Store within this month (assuming the review doesn’t take too long), which matches what I mentioned in #1264 (comment). So I’m not in a rush to push the pace right now.

[MohitMandalia]

No worries @Tlaster I would like to help you in this project can you guide me on where do you need help so that this project can progress faster.

Thanks for following up!

Regarding repository testing: I’m still thinking through what the best testing strategy should be. Flare went through a lot of rapid iteration early on, and testing wasn’t fully considered in the original design. Some parts ended up being fairly ad-hoc (e.g. parts of AccountRepository.kt), so adding proper tests now requires extra refactoring work first. And since these repositories are foundational (most presenters depend on them), any changes there need to be done very carefully.

As for project progress, things are already moving forward steadily according to the plan. For the next major milestone, iOS is expected to go live on the App Store within this month (assuming the review doesn’t take too long), which matches what I mentioned in #1264 (comment). So I’m not in a rush to push the pace right now.

Ya that's why I had to write one test in jvmMain as it needed the PlatformPathProducer. Thanks for letting me know the plan also let me help you if possible in any way till then I would think some strategies for testing.