Skip to content

Issue 1671: Bluesky reply duplication#1800

Merged
Tlaster merged 2 commits intoDimensionDev:masterfrom
danguyf:feature/1671-bluesky_reply_duplication
Feb 16, 2026
Merged

Issue 1671: Bluesky reply duplication#1800
Tlaster merged 2 commits intoDimensionDev:masterfrom
danguyf:feature/1671-bluesky_reply_duplication

Conversation

@danguyf
Copy link
Contributor

@danguyf danguyf commented Feb 15, 2026

Issue: #1671

This addresses the case in the linked issue. (Listed in chronological order, bottom to top.)
Current: A, B->A
Desired: B->A

It also addresses reply chains.
Current: A, B->A, C->B
Desired: C->B->A

(I, personally, would prefer that replies were displayed in chronological order, e.g. A->B->C reading bottom to top, but that is not the current behavior of the Twitter and Mastodon feeds so I didn't change it.)

@danguyf danguyf changed the title Feature/1671 bluesky reply duplication Issue 1671: Bluesky reply duplication Feb 15, 2026
@Tlaster Tlaster requested a review from Copilot February 16, 2026 06:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the Bluesky reply duplication issue where posts in a reply chain were shown both as standalone posts and as part of the chain. The fix ensures that only the leaf post of a reply chain is displayed, with all parent posts shown as part of that chain.

Changes:

  • Modified the database cache mapper to build complete parent chains and filter out intermediate posts that appear as parents of other posts in the feed
  • Updated the UI mapper to display all parents in a chain (reversed for chronological order) instead of only the immediate parent

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
shared/src/commonMain/kotlin/dev/dimension/flare/data/database/cache/mapper/Bluesky.kt Refactored toDbPagingTimeline to build parent chain maps, identify duplicate parent posts, and filter them out; extracted processBlueskyFeedItem helper function
shared/src/commonMain/kotlin/dev/dimension/flare/ui/model/mapper/Bluesky.kt Modified parent rendering to display all parents in the reference chain (reversed) instead of only the first parent

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@Tlaster Tlaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's still room for improvement, but not right now. LGTM!

@Tlaster Tlaster merged commit d00b91b into DimensionDev:master Feb 16, 2026
13 checks passed
@danguyf danguyf deleted the feature/1671-bluesky_reply_duplication branch February 18, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments