fix(farcaster): mf-6717 use username for farcaster identity (#12232)

Author: swkatmask

packages/mask/popups/pages/Friends/ContactCard/ConnectedAccounts/index.tsx

@@ -36,7 +36,7 @@ interface ConnectedAccountsProps {
     localProfile?: ProfileIdentifier
 }
 
-export const ConnectedAccounts = memo<ConnectedAccountsProps>(function ({
+export const ConnectedAccounts = memo<ConnectedAccountsProps>(function ConnectedAccounts({
     avatar,
     nextId,
     profiles,

packages/plugins/Web3Profile/src/SiteAdaptor/components/SocialBadges/FarcasterList.tsx

@@ -74,11 +74,11 @@ interface FarcasterListItemProps {
 
 const FarcasterListItem = memo<FarcasterListItemProps>(function FarcasterListItem({ account }) {
     const { classes } = useStyles()
-    const profileUri = `https://firefly.social/profile/farcaster/${account.fid}`
+    const profileUri = `https://firefly.social/profile/farcaster/${account.username}`
     const farcasterIcon = <Icons.Farcaster size={30} />
 
     return (
-        <ListItem className={classes.listItem} key={account.fid}>
+        <ListItem className={classes.listItem} key={account.username}>
             <div className={classes.avatarContainer}>
                 {profileUri.length ?
                     <Image

packages/shared/src/UI/components/SocialAccountList/index.tsx

@@ -73,7 +73,7 @@ const FireflyLensToWeb3BioProfile = (account: FireflyConfigAPI.LensAccount): Web
 const FireflyFarcasterToWeb3bioProfile = (account: FireflyConfigAPI.FarcasterProfile): Web3BioProfile => {
     return {
         platform: NextIDPlatform.Farcaster,
-        identity: account.fid.toString(),
+        identity: account.username,
         address: account.signer_address,
         displayName: account.display_name,
         avatar: account.avatar.url,

packages/web3-providers/src/Web3Bio/index.ts

@@ -12,16 +12,6 @@ type Response<T> =
           error: string
       }
 
-function patchProfile(profile: Web3BioProfile): Web3BioProfile {
-    if (profile.platform === NextIDPlatform.Farcaster && profile.social?.uid) {
-        return {
-            ...profile,
-            identity: profile.social.uid.toString(),
-        }
-    }
-    return profile
-}
-
 export class Web3Bio {
     static fetchFromWeb3Bio<T>(request: Request | RequestInfo, init?: RequestInit) {
         return fetchCachedJSON<T>(request, {
@@ -34,21 +24,21 @@ export class Web3Bio {
 
     static async getProfilesByTwitterId(handle: string) {
         const url = urlcat(WEB3_BIO_HOST, `/profile/twitter,${handle.toLowerCase()}`)
-        const res = await Web3Bio.fetchFromWeb3Bio<Response<Web3BioProfile[]>>(url)
-        return Array.isArray(res) ? res.map(patchProfile) : []
+        const profiles = await Web3Bio.fetchFromWeb3Bio<Response<Web3BioProfile[]>>(url)
+        return Array.isArray(profiles) ? profiles : []
     }
 
     /** Get profiles by address or domain */
     static async getProfilesBy(domainOrAddress: string) {
         const url = urlcat(WEB3_BIO_HOST, '/profile/:id', { id: domainOrAddress })
-        const res = await Web3Bio.fetchFromWeb3Bio<Response<Web3BioProfile[]>>(url)
-        return Array.isArray(res) ? res.map(patchProfile) : []
+        const profiles = await Web3Bio.fetchFromWeb3Bio<Response<Web3BioProfile[]>>(url)
+        return Array.isArray(profiles) ? profiles : []
     }
 
     static async getProfilesByNextId(pubkey: string) {
         const url = urlcat(WEB3_BIO_HOST, '/profile/nextid,:pubkey', { pubkey })
-        const res = await Web3Bio.fetchFromWeb3Bio<Response<Web3BioProfile[]>>(url)
-        return Array.isArray(res) ? res.map(patchProfile) : []
+        const profiles = await Web3Bio.fetchFromWeb3Bio<Response<Web3BioProfile[]>>(url)
+        return Array.isArray(profiles) ? profiles : []
     }
 
     static async getAllLens(twitterId: string) {