Skip to content

Conversation

@developerfred
Copy link
Contributor

@developerfred developerfred commented Dec 24, 2021

Description

Optimism integration on MaskBook

Closes #4868

Type of change

  • add optimist Layer2
  • add UniswapV3
  • enable UnlockProtocol
  • enable dHedge

Token List

Dex

  • Uniswap
  • Juggler.red

Mask Assets

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

@developerfred developerfred changed the base branch from develop to master December 24, 2021 03:08
Jack-Works
Jack-Works previously approved these changes Dec 26, 2021
Copy link
Member

@Jack-Works Jack-Works left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guanbinrui
Copy link
Member

guanbinrui commented Dec 27, 2021

Hi @developerfred, we've completed the EVM chain integration document. Would you please read the checklist to ensure you didn't miss anything? Also, if there is something we didn't mention. Please let us know it.

Learn more: https://github.com/DimensionDev/Maskbook/blob/develop/docs/evm-integration.md

@developerfred
Copy link
Contributor Author

Hi @developerfred, we've completed the EVM chain integration document. Would you please read the checklist to ensure you didn't miss anything? Also, if there is something we didn't mention. Please let us know it.

Learn more: develop/docs/evm-integration.md

OK, I'm going to check the list and do a check up

@developerfred developerfred force-pushed the codingsh/Integrate-Optimism branch from c8bacbd to 4d71edc Compare December 30, 2021 01:49
@developerfred developerfred changed the base branch from master to develop December 30, 2021 07:09
@developerfred developerfred force-pushed the codingsh/Integrate-Optimism branch from d6bf0aa to 3778cd3 Compare December 30, 2021 07:26
@AinuX
Copy link
Collaborator

AinuX commented Jul 5, 2022

@developerfred

  1. First time to reach Optimism, report an error

image

2. Token icon is incorrect

image

3. Connect to Optimism, chain icon showed as ETH

image

4. Swap not work, and also did not see Uniswap, Juggler.red in swap provider list.
iShot_2022-07-05_15.03.50.mp4
  1. Incorrect chain info in twitter share, maybe it's the same root cause like issue 2

image

6. ITO not work.
  1. Gas setting not work

image

  1. Fail to transfer token with mask wallet.
    https://user-images.githubusercontent.com/2582974/177274360-a42bd443-b2b7-4b43-aa42-8efb7b9355d9.mp4

@nuanyang233 nuanyang233 force-pushed the codingsh/Integrate-Optimism branch from 0ccdfcf to da5a4a1 Compare July 26, 2022 15:20
@nuanyang233 nuanyang233 force-pushed the codingsh/Integrate-Optimism branch from d09a9af to 7628600 Compare July 26, 2022 15:31
@guanbinrui guanbinrui merged commit fcea3b0 into DimensionDev:develop Aug 3, 2022
@developerfred
Copy link
Contributor Author

Uhulll @guanbinrui @nuanyang233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bounty] Integrate Optimism into Mask

8 participants