Skip to content

Conversation

@guanbinrui
Copy link
Member

@guanbinrui guanbinrui commented Jun 2, 2023

Description

MF-0000

Closes #9738
Closes #9737
Closes #9735
Closes #9734

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@guanbinrui guanbinrui added this to the 2.22.0 milestone Jun 2, 2023
@guanbinrui guanbinrui changed the title chore: upgrade web3 skd chore: upgrade web3 SDK Jun 2, 2023
@github-actions github-actions bot temporarily deployed to pull request June 2, 2023 03:15 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 6, 2023 06:04 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 6, 2023 07:43 Inactive
@guanbinrui guanbinrui force-pushed the chore/update-web3-sdk branch 2 times, most recently from e022dfb to 40bbe3c Compare June 6, 2023 07:56
@guanbinrui guanbinrui force-pushed the chore/update-web3-sdk branch from 40bbe3c to 62c8779 Compare June 6, 2023 08:00
@github-actions github-actions bot temporarily deployed to pull request June 6, 2023 08:08 Inactive
@guanbinrui guanbinrui closed this Jun 7, 2023
@guanbinrui guanbinrui deleted the chore/update-web3-sdk branch June 7, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants