Skip to content

Disable full fetch on local and federated timelines#2355

Merged
Dimillian merged 1 commit intomainfrom
codex/disable-full-timeline-fetch-for-timelines
Oct 26, 2025
Merged

Disable full fetch on local and federated timelines#2355
Dimillian merged 1 commit intomainfrom
codex/disable-full-timeline-fetch-for-timelines

Conversation

@Dimillian
Copy link
Owner

Summary

  • ensure the full timeline fetch preference does not apply to local and federated timelines so they continue using gap pagination

Testing

  • not run

https://chatgpt.com/codex/tasks/task_e_68fdb02ca3ac8325a9f366fb80b21197

@Dimillian
Copy link
Owner Author

@codex review

@Dimillian Dimillian requested a review from Copilot October 26, 2025 05:28
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR disables the full timeline fetch preference for local and federated timelines, ensuring these timelines continue to use gap pagination regardless of the user's full fetch setting.

Key changes:

  • Modified isFullTimelineFetchEnabled to return false for local and federated timeline types, even when the user preference is enabled

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Keep it up!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Dimillian Dimillian merged commit 85d7312 into main Oct 26, 2025
2 checks passed
jesusjimsa pushed a commit to jesusjimsa/IceCubesApp that referenced this pull request Nov 28, 2025
rrgeorge pushed a commit to rrgeorge/IceCubesApp that referenced this pull request Dec 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants