Fix timeline fetching when content filters hide all statuses

[Dimillian]

Motivation

• Users reported empty timelines when content filters were active and hid all visible statuses.
• The timeline datasource already fetched pages but the UI remained empty because no additional pages were automatically loaded when filters removed all visible items.
• The change aims to auto-load older pages until at least one unfiltered status is found or a safe page limit is reached.
• This should make filtered timelines resilient when many statuses are filtered out by user settings or server filters.

Description

• Added new constants filteredTimelineAutoFetchLimit and filteredTimelineAutoFetchMaxPages in TimelineViewModel.swift to control auto-fetch thresholds.
• Implemented maybeLoadMoreForFilteredTimeline which uses statusFetcher.fetchNextPage to append pages when datasource.getFilteredItems() is empty but datasource.getItems() is not empty.
• Wire maybeLoadMoreForFilteredTimeline into content-filter refresh and timeline update paths by calling it from refreshTimelineContentFilter, updateTimelineWithNewStatuses, and updateDatasourceAndState.
• Protect reentrancy with isAutoLoadingFilteredTimeline and stop loading when visible items appear, page limits are reached, or smaller-than-threshold pages are returned.

Testing

• No automated tests were run in this environment because the Xcode build/test tools were not executed here.
• The change was added and committed to Packages/Timeline/Sources/Timeline/View/TimelineViewModel.swift but compilation and unit tests should be run locally via Xcode or xcodebuild before merging.
• Recommended tests to run: xcodebuild -scheme TimelineTests test and the app build for the target simulator to verify UI behaviour under various filter configurations.
• Please run timeline filtering unit tests and a manual smoke test of filtered timelines to confirm the fix on a real instance.

---

Codex Task

---

Note

Makes filtered timelines resilient when content filters hide all currently visible statuses.

• Adds Constants.filteredTimelineAutoFetchLimit and filteredTimelineAutoFetchMaxPages to bound auto-loading
• Implements maybeLoadMoreForFilteredTimeline to iteratively call fetchNextPage until unfiltered items appear, limits are hit, or a short page is returned; guarded by isAutoLoadingFilteredTimeline
• Wires auto-loading into refreshTimelineContentFilter, updateTimelineWithNewStatuses, and updateDatasourceAndState so the UI populates after filtering updates

^{Written by Cursor Bugbot for commit ebddf1b. This will update automatically on new commits. Configure here.}

[Dimillian]

@codex review

[cursor]

This PR is being reviewed by Cursor Bugbot

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

[cursor]

Race condition in auto-fetch reentrancy guard

The reentrancy flag isAutoLoadingFilteredTimeline is checked at line 539 but not set to true until line 544, after two await suspension points at lines 541-542. In Swift's actor model, other code on @MainActor can run during these suspensions. Multiple calls to maybeLoadMoreForFilteredTimeline could pass the guard before any sets the flag, causing concurrent execution of the auto-load loop with duplicate network requests and potentially duplicate items appended to the datasource.

 

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Treat gaps as empty when deciding auto-load

The guard here uses getFilteredItems().isEmpty, but getFilteredItems() always includes .gap entries. If a gap exists (e.g., after a prior pagination inserted one) and content filters hide all statuses, this check returns false and the auto-load is skipped even though there are zero visible statuses. That leaves the timeline effectively empty and defeats the intended “load until an unfiltered status appears” behavior. Consider checking getFiltered() or explicitly ignoring gaps when deciding to bail.

Useful? React with 👍 / 👎.

[Dimillian]

@codex double Check and fix it

[chatgpt-codex-connector]

Summary

• Updated filtered timeline auto-load checks to ignore gaps and use filtered statuses when deciding to fetch more pages.
• Moved the auto-load reentrancy flag assignment ahead of async awaits to avoid concurrent auto-fetch loops.

Testing

• ⚠️ Not run (Xcode build tools not available in this environment).

View task →