Fix line-start dash rendering in status content#2391
Merged
Conversation
rrgeorge
pushed a commit
to rrgeorge/IceCubesApp
that referenced
this pull request
Dec 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
-,*or+was being interpreted as Markdown list markers and rendered as list items instead of literal text.HTMLStringmust preserve literal leading list markers when they appear at the start of a line in the original content.Description
Packages/Models/Sources/Models/Alias/HTMLString.swiftto detect line starts when handling#textnodes and escape leading list markers by prefixing them with a backslash so they render as literal characters.asMarkdownis empty or ends with a newline and escapes markers matching-,*or+.testHTMLStringInit_lineStartListMarkersinPackages/Models/Tests/ModelsTests/HTMLStringTests.swiftthat verifies a<br />-sequence is preserved as\-inasMarkdown.Testing
testHTMLStringInit_lineStartListMarkersto cover the regression scenario and ensure literal leading markers are escaped.xcodebuild/swift testnot run here).Codex Task
Note
Prevents accidental list rendering when status text starts with list-like markers.
HTMLString.handleNode(#text)to detect line starts (empty output or after\n) and prefix leading-,*,+with a backslash before appending toasMarkdowntestHTMLStringInit_lineStartListMarkersverifying<br />-becomes\-inasMarkdownwhileasRawTextremains unchangedWritten by Cursor Bugbot for commit fb30f7a. This will update automatically on new commits. Configure here.