feat: add preference to hide posts containing media (#2382) #2400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thunderxx2
force-pushed
the
feat/hide-media-posts-v2
branch
from
827648b to
ffb2759
Compare
Owner
Hmmm ? I think you need to do localization as part of another PR and be careful not to break or change the file formatting
|
thunderxx2
force-pushed
the
feat/hide-media-posts-v2
branch
from
ffb2759 to
9e6a69e
Compare
Contributor
Author
Hi @Dimillian , I've moved the localization to a separate PR here: [/pull/2406]. This PR is now strictly focused on the filtering logic. Ready for review! |
thunderxx2
force-pushed
the
feat/hide-media-posts-v2
branch
from
9e6a69e to
01e3783
Compare
Dimillian
reviewed
Jan 4, 2026
| case .status(let status): | ||
| if shouldShowStatus(status, filter: snapshot) { | ||
| filtered.append(item) | ||
| if !hideMedia || status.mediaAttachments.isEmpty { |
Owner
There was a problem hiding this comment.
This should be directly in the shouldShowStatus function
Contributor
Author
There was a problem hiding this comment.
Hi @Dimillian, thanks for the feedback! I've refactored the PR to align with your suggestions and improved the UI layout:
- Logic Refactor: Moved the media filtering check directly into the shoudShowStatus function
- Architecture & Decoupling: Removed the UserPreferences dependency from the view. I've now placed the preference into TimelineContentFilter and included it in the Snapshot.
- UI Polish: Moved the toggle to 'Content Filter' section in Settings for better grouping
- Iconography: Added the
photo.on.rectangle.angledSF symbol to match the existing list style and ensure compatibility across iOS versions - Localization: Updated the key to timeline.filter.hide-posts-with-media for better consistency.
Let me know if this looks better!
added 5 commits
January 6, 2026 02:48
thunderxx2
force-pushed
the
feat/hide-media-posts-v2
branch
from
71724b1 to
263ff38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements a new user preference to filter out posts containing media attachments from the timeline, as requested in issue #2382.
Changes
hidePostsWithMediatoUserPreferencesusing@AppStoragefor persistent state management.ContentSettingsView.swiftallowing users to enable/disable media filtering.TimelineDatasource.swiftto exclude media-heavy posts during new status fetches.TimelineListView.swiftto reactively filter the current display list, ensuring posts disappear/reappear instantly when the setting is toggled.settings.content.media.hide-posts-with-mediatoLocalizable.xcstringswith support for multiple English locales (en, en-GB, ca).Impact
Users who prefer a text-only or low-bandwidth experience can now hide all media-based posts across their timelines.
Screenshots / Video
Testing Performed
Closes #2382