Update readme about long class file names#100
Merged
EpicPlayerA10 merged 3 commits intoDiobf:masterfrom May 23, 2025
Merged
Conversation
EpicPlayerA10
requested changes
May 21, 2025
Collaborator
EpicPlayerA10
left a comment
EpicPlayerA10
left a comment
There was a problem hiding this comment.
Thank you for the pull request!
Yeah, i have renamed the classes that had long paths to shorter ones and now this requirement of setting core.longpaths is not needed.
Before merging your PR, I would like to request some changes. Especially, move this notice about long path to CONTRIBUTING.md as it is a file for developers to read.
You can also remove this line as it is no longer needed:
https://github.com/narumii/Deobfuscator/blob/f7424276c5aaca271f5e7affecfe0cd63971216e/README.md?plain=1#L10
Remove unnecessary Git configuration content and add new precautions
EpicPlayerA10
requested changes
May 22, 2025
CONTRIBUTING.md
Outdated
|
|
||
| The project is also greatly documented, so you can find more information about any class or transformer in their javadocs and comments inside the code. You can also view other transformers' code - see how they work and how they are implemented. There are also tests, so you can, for example, see how the transformer behaves when you modify some line of code. | ||
|
|
||
| ## ❗Attention |
Collaborator
There was a problem hiding this comment.
Move this Attention section to the very bottom of the file.
Contributor
Author
There was a problem hiding this comment.
I fix the small nitpick
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think we should avoid the problem of file names being too long instead of modifying Git settings, as this would require more operations. And in old version Windows has some limit about file path, the MAX_PATH is 260.