Skip to content

A small fix for Allatori#129

Open
huzpsb wants to merge 2 commits intoDiobf:masterfrom
huzpsb:master_alla
Open

A small fix for Allatori#129
huzpsb wants to merge 2 commits intoDiobf:masterfrom
huzpsb:master_alla

Conversation

@huzpsb
Copy link

@huzpsb huzpsb commented Mar 14, 2026

[!] I'm not really used to code quality so this PR may require some heavy refactoring, sry

Fixes #127

Copy link
Contributor

@Animowany Animowany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd use ComposedTransformer with rerunOnChange instead of 3 times calling AST instance

@huzpsb
Copy link
Author

huzpsb commented Mar 18, 2026

I'd use ComposedTransformer with rerunOnChange instead of 3 times calling AST instance

Maybe we shoudl use ow2.asm tracker and get rid of that left-out flag when possible i'd say

ddde3cc64aa13cd63937ccf125a68519

For instance, line 31->48, um

Howerver idk y but that fails from time to time (especially if you have some libraries missing) and I'd prefer use it as less as possible

So...

Copy link
Collaborator

@EpicPlayerA10 EpicPlayerA10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add a test sample of allatori?

@huzpsb
Copy link
Author

huzpsb commented Mar 18, 2026

Could you also add a test sample of allatori?

https://github.com/user-attachments/files/25996497/sample.zip

This one in #127 should be one i suppose?

@EpicPlayerA10
Copy link
Collaborator

Could you also add a test sample of allatori?

https://github.com/user-attachments/files/25996497/sample.zip

This one in #127 should be one i suppose?

I meant to add it to the test system https://github.com/narumii/Deobfuscator/wiki/4.-Understanding-Tests-System

@huzpsb
Copy link
Author

huzpsb commented Mar 18, 2026

Could you also add a test sample of allatori?

https://github.com/user-attachments/files/25996497/sample.zip
This one in #127 should be one i suppose?

I meant to add it to the test system https://github.com/narumii/Deobfuscator/wiki/4.-Understanding-Tests-System

    public static boolean ALLATORIxDEMO(String param0, String param1) {
        // $VF: Couldn't be decompiled
        // Please report this to the Vineflower issue tracker, at https://github.com/Vineflower/vineflower/issues with a copy of the class file (if you have the rights to distribute it!)
        // java.lang.RuntimeException: parsing failure!
        //   at org.jetbrains.java.decompiler.modules.decompiler.decompose.DomHelper.parseGraph(DomHelper.java:211)
        //   at org.jetbrains.java.decompiler.main.rels.MethodProcessor.codeToJava(MethodProcessor.java:166)
        //
        // Bytecode:
        // 000: aload 0
        // 001: astore 2
        // 002: aload 2
        // 003: astore 0
        // 004: getstatic com/damowang/iiIiIIIIiI.IiIiiiIiIi Z
        // 007: ifne 012
        // 00a: ldc_w "【大魔王云加载工具】 加载失败:工具类未初始化!"
        // 00d: invokestatic ch/njol/skript/Skript.error (Ljava/lang/String;)V
        // 010: bipush 0
        // 011: ireturn
        // 012: aload 0
        // 013: ifnull 020
        // 016: aload 0
        // 017: invokevirtual java/lang/String.trim ()Ljava/lang/String;
        // 01a: invokevirtual java/lang/String.isEmpty ()Z
        // 01d: ifeq 028
        // 020: ldc_w "【大魔王云加载工具】 加载失败:URL不能为空!"
        // 023: invokestatic ch/njol/skript/Skript.error (Ljava/lang/String;)V
        // 026: bipush 0
        // 027: ireturn

That VF doesn't seem to be happy with this class 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allatori issue

3 participants