Add component Card #155
Merged
Add component Card #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview available at https://dioxuslabs.github.io/components/pr-preview/pr-155/ |
ealmloff
approved these changes
Nov 29, 2025
Member
ealmloff
left a comment
ealmloff
left a comment
There was a problem hiding this comment.
Thanks for working on this! Looks great overall, I pushed some changes to better match the dark mode styling in shadcn and removed the playwright tests since there isn't any behavior we can test with playwright here outside of the styling
Contributor
Author
|
I notice that the changes in card background is bad in light mode. |
Member
|
Yes, that should be fixed by 3d9ad64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feat #77
Add component card