-
Notifications
You must be signed in to change notification settings - Fork 42
Add sheet component #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sheet component #162
Conversation
|
Preview available at https://dioxuslabs.github.io/components/pr-preview/pr-162/ |
|
I think this is roughly as good as we can make this interface with dioxus today. Eventually I would like something like this to be possible with props which would make it easier to extend an arbitrary component instead of just attributes: https://docs.rs/frunk/latest/frunk/labelled/trait.Transmogrifier.html I think solidjs requires dynamic because of its rendering model. Since dioxus does diffing, you should just be able to call the |
2e674ef to
475cd8c
Compare
|
What I updated:
|
…for better consistency with other components
ealmloff
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is fantastic! I'm glad to see this only required very minimal changes to dioxus-primitive itself
feature:
Add new component sheet (#158)
content:
dangerous update might need revalidate:
utilsfordynamiccomponent. Inspired by:- hngngn/shadcn-solid,
- corvudev/corvu
, who implement a
dynamicinfra to make anasChild-likefeature. (I don't know whethere it's a good choice or not)