Add light/dark mode toggle to the preview #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview available at https://dioxuslabs.github.io/components/pr-preview/pr-51/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a light/dark mode toggle for the preview site. The CSS diff here is large because we need to switch how we style light and dark mode. You can't change media queries with JavaScript, but we want to default to using media queries to implement light and dark mode without requiring javascript. This PR switches to this syntax:
var(--light, light-mode-only-styles) var(--dark, dark-mode-only-styles)The
styles.cssstylesheet sets up these css variables based on media queries. While the syntax is a bit odd, this works without javascript and can easily be overwritten by the toggle