Add wasm32 target for cargo clippy with --all-targets in CI #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview available at https://dioxuslabs.github.io/components/pr-preview/pr-97/ |
ealmloff
reviewed
Dec 5, 2025
Member
ealmloff
left a comment
ealmloff
left a comment
There was a problem hiding this comment.
The components don't have any platform specific code. It might make sense to add something like this with a platform matrix if we do add some platform specific code, but I would like to avoid it if we can
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thus, we can ensure that some change is not unintendedly incompatible with the wasm32 target.
I realized that
cargo clippywith--all-targets, not--target wasm32-unknown-unknown, may not catch wasm incompatibility