Skip to content

Conversation

wangfu91
Copy link

This pull request enhances the display of build durations in the terminal by adopting a more user-friendly formatting style.

The change replaces raw millisecond values with formatted durations using the humantime crate, making it easier to read and interpret.

Before:
sanpshot-before

After:
sanpshot-after

Replaces manual millisecond formatting with humantime::format_duration for improved readability of build duration logs. Adds humantime as a dependency in Cargo.toml.
Changed build duration logging to use millisecond precision instead of default formatting to avoid microsecond/nanosecond noise.
@Copilot Copilot AI review requested due to automatic review settings August 20, 2025 11:48
@wangfu91 wangfu91 requested a review from a team as a code owner August 20, 2025 11:48
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the CLI build duration output by replacing raw millisecond values with human-readable formatting using the humantime crate. This improves user experience by making build durations easier to interpret.

Key Changes

  • Replaces millisecond duration output with human-readable format (e.g., "1.5s" instead of "1500ms")
  • Adds the humantime dependency to format durations with millisecond precision
  • Updates two build completion log messages in the CLI runner

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.

File Description
packages/cli/src/serve/runner.rs Updates build completion logging to use human-readable duration formatting
packages/cli/Cargo.toml Adds humantime dependency for duration formatting

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant