Support custom asset mount paths #4779
Open
+274
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add optional mount_path to manganis AssetOptions + builders - have CLI honor mount paths when copying assets and generating URLs - update HTML preload injection, docs, and hotreload notifications - honor AssetOptions mount_path across every bundle type - serve native assets from mount directories via resolver fallback - ensure Android hotreload pushes files into mount-aware locations Tests: cargo test -p manganis-core; cargo check -p dioxus-cli
tekacs
force-pushed
the
asset-mount-path
branch
5 times, most recently
from
a181450 to
47a829e
Compare
|
I spent some time trying to get the asset pipeline to correctly delete files that had been removed (with a manifest), but it proved fiddly with too many edge cases, so I've separated out that work for now. Compared to the simpler asset dir implementation, this is fiddlier (in particular hot patching deserves a close look), but feels clean and correct in use. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #4778 for more details and motivation!
Tests: cargo test -p manganis-core; cargo check -p dioxus-cli