Add set_pointer_capture() and Fix set_focus() bug in MountedData #5167
+213
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ealmloff
added
breaking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds [set_pointer_capture()] and [release_pointer_capture()] methods to trait [RenderedElementBacking], making them available through [MountedData] across platforms without using web-sys. I'm not sure if this aligns with Dioxus' current development roadmap, but believe it could be very helpful for users to implement pointer-driven drag-and-drop functionality. (such as resize panels)
While modifying "dioxus-interpreter-js"'s "native.ts" for above changes, I found a bug in [set_focus()] implements for desktop and liveview environments: [setFocus()] in "native.ts" must return boolean type explicitly not to make panic in [set_focus()]. This PR fixes that too.