-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Experimental wasm multithreaded hotpatch #5192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
qouteall
wants to merge
38
commits into
DioxusLabs:main
Choose a base branch
from
qouteall:wasm_mt_4
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement hotpatching for Wasm multithreading.
__wasm_init_memoryfunction instructions to know the in-linear-memory offset of passive data segments.--disable-js-glue-shimto avoid wrongly loading Wasm in web worker.experimental_wasm_multithreading_support)init_hotpatch_for_current_threadon startup to initializeBroadcastChannelto communicate. (This is less intrusive than controlling web worker message callback or requring passing aMessageChannel,)i32.waitdylink.0section to know data size to reduce memory waste (TODO this can also be applied to single-threaded hotpatching)assets::find_wasm_symbol_offsetsI removed hardcoded offset (doesn't work in my case) and uses passive segment offset obtained by parsing__wasm_memory_init. As I tested, in--releaseit still have function name during asset processing.Example to test: https://github.com/qouteall/RustWasmMultithreadingHotswapExample
Other things: