cli: retry template clone with sanitized gitconfig #5216
+387
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3319
dx newuses cargo-generate/libgit2 to clone templates. If a user hasurl.*.insteadOfrewrites in their global git config (e.g. rewritinghttps://github.com/to an SSH/custom host), libgit2 can fail withclass=Os/timeouts anddxwould not hit the sanitized gitconfig retry.This change makes the sanitized retry apply to any cargo-generate clone failure (using cargo-generate's common wrapper error), and treats cargo-generate panics as retryable.
Tests:
cargo fmt --all -- --checkcargo clippy --workspace --exclude dioxus-desktop --examples --tests --all-features --all-targets -- -D warningsNDK_HOME=C:\\dummy-ndk cargo test --workspace --testscargo test --doc --workspace --all-featurestarget\\release\\dx.exe newwithurl.insteadOfrewritingfile:///->ssh://[email protected]:1/