Fix: make component install atomic and revert partial filesystem chan… #5218
+140
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When running
dx components listordx components addon a fresh setup (with no existing components), a failure during download or installation could leave a partially-created state under.dx/components/.Specifically:
componentsdirectory (and subdirectories) could be createdcomponent.jsonis writtenos error 2due to missing or incomplete manifestsThis leaves the CLI in a broken state that requires manual cleanup.
Solution
This PR makes component installation atomic by introducing a validation-first, commit-later flow:
.dx/components/<component>path until all validation succeedsAs a result, failures no longer leave behind partial or corrupted state.
Why this is safe
Testing
.dx/componentsstate