Merged
Conversation
marc2332
requested changes
Apr 5, 2025
sdk/src/utils/scroll.rs
Outdated
Comment on lines
+69
to
+73
| let future_callback_name = callback_name.clone(); | ||
| use_future(move || { | ||
| let future_callback_name = future_callback_name.clone(); | ||
| async move { | ||
| let callback_name = future_callback_name; |
Collaborator
There was a problem hiding this comment.
Just a suggestion to simplify this part:
Suggested change
| let future_callback_name = callback_name.clone(); | |
| use_future(move || { | |
| let future_callback_name = future_callback_name.clone(); | |
| async move { | |
| let callback_name = future_callback_name; | |
| use_future({ | |
| to_owned![callback_name]; | |
| move || { | |
| to_owned![callback_name]; | |
| async move { |
Contributor
Author
There was a problem hiding this comment.
Done. PR seems to be stuck in "processing updates" for the past 10 min though.
Contributor
Author
There was a problem hiding this comment.
10 hours later and still processing.. weird, had to amend and force push the same commit, but it is showing now.
Contributor
DogeDark
approved these changes
Apr 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a hook to react to root scrolling