Implement PHPStan up to level 2 #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CReimer
commented
Sep 27, 2025
| { | ||
| if ($date = $this->header(HeaderConsts::DATE)?->getDateTime()) { | ||
| return Carbon::instance($date); | ||
| $dateHeader = $this->header(HeaderConsts::DATE); |
Contributor
Author
There was a problem hiding this comment.
That's what I mean. That's my prefered approach. Runtime checking for the right instance
CReimer
commented
Sep 27, 2025
| { | ||
| /** @var UntaggedResponse $response */ | ||
| if (! $response = $this->id($id, $identifier)->first()) { | ||
| $response = $this->id($id, $identifier)->first(); |
Contributor
Author
There was a problem hiding this comment.
And that's your approach. I changed it to have $response directly at the DocTag. It's easier to understand this way... and PHPStan understands it this way
CReimer
commented
Sep 27, 2025
| return $this->connection()->fetch($fetch, $uids->all())->mapWithKeys(function (UntaggedResponse $response) { | ||
| $data = $response->tokenAt(3); | ||
|
|
||
| if (!$data instanceof ListData) { |
Contributor
Author
There was a problem hiding this comment.
I'm not sure as of right now how you approach exceptions. This is more or less a third approach. For the same problem. -> method returns parent, but specific child is expected
Member
There was a problem hiding this comment.
Yea I think this is a good approach -- best to throw an exception here like you've implemented 👍
stevebauman
approved these changes
Sep 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After level 1 follows level 2
Nothing too exciting here, i guess.
One thing I want to point out. I prefer to check for the right instance in runtime. I just found out you seem to prefer, to declare the type as it should be.
My runtime check makes sure it's the right instance while running
Your approach is valid, too. It should ideally never be different than expected... but it might be