Implement PHPStan up to level 3 #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CReimer
commented
Sep 29, 2025
| protected function assertTaggedResponse(string $tag, ?callable $exception = null): TaggedResponse | ||
| { | ||
| return $this->assertNextResponse( | ||
| /** @var TaggedResponse $response */ |
Contributor
Author
There was a problem hiding this comment.
I'm a bit unhappy with this one. Everything says It is "TaggedResponse", but the method signature of assertNextResponse is too complex for PHPStan to understand it directly. This way we do a type coercion and return it afterwards. I don't see a cleaner solution for this, without significantly changing how assert*Response works.
Member
There was a problem hiding this comment.
This is totally fine with me! 👍
stevebauman
approved these changes
Sep 29, 2025
Member
stevebauman
left a comment
stevebauman
left a comment
There was a problem hiding this comment.
Nice! This looks great, thanks! 🙏
| protected function assertTaggedResponse(string $tag, ?callable $exception = null): TaggedResponse | ||
| { | ||
| return $this->assertNextResponse( | ||
| /** @var TaggedResponse $response */ |
Member
There was a problem hiding this comment.
This is totally fine with me! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as before. This time the branch is not locked 😄
Most of these changes are contradicting return types. PHP return type says MessageInterface vs. PHPDoc says Message. I switched everything around to the interface as it better aligns with the "user can override everything"-idea.
I changed the template tags of ResponseCollection around. I'm no expert in these, but bevore PHPStan had problems understanding the generic, with this change it works out-of-the box.