Implement PHPStan up to level 4 #116
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New day. New PHPStan level.
Most of these are just type narrowings. But I think we need to talk more about ImapConnection.php
ImapConnection::nextReply had a return type of Data|Token|Response|null
The null type made it possible for the while loop in ImapConnection::nextResponse to break. This made it possible to reach the throw at the end.
ImapConnection::nextResponse does not have null as return type. This makes it impossible to reach the throw in ImapConnection::assertNextResponse.
I don't see how ImapConnection::nextReply can reach null as return value. Therefore I removed all while loops on the way up from there.