Ensure message UID sorting is consistent #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do I understand correctly that the list are only sorted by the email ids/uids without taking into account the email headers? Sorry for the meticulousness. |
Member
Author
|
@liuch Yes you're correct. We may not have access to the message headers (since they must be requested for in the query builder via |
|
The names of the methods misled me. Thank you for the response. BTW: You might want to consider this: #80 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #92
As discovered by @liuch, we're assuming IMAP UIDs will always return in ascending order, which isn't the case with all providers. This PR ensures sorting is done on retrieved UIDs in a consistent manner across all IMAP servers.