Skip to content

eng-1262: allow for same id, different triples #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maparent merged 2 commits into from
Jan 12, 2026
Merged

eng-1262: allow for same id, different triples #679

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5aad6c1
eng-1262: allow for same id, different triples
maparent Jan 8, 2026
394f847
correction
maparent Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions apps/roam/src/components/CreateRelationDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,13 +133,18 @@ const CreateRelationDialog = ({
});
return null;
}
if (candidateRelations.length !== 1) {
// This seems to happen... I need more data.
internalError({
type: "Create Relation dialog",
error: `Too many relations between ${selectedTargetType.type} and ${selectedSourceType.type}: ${candidateRelations.map((r) => r.id).join(",")}`,
});
return null;
if (candidateRelations.length > 1) {
// Control for one very innocuous case: Many times the same relation, with different triples.
const setOfRels = new Set(
candidateRelations.map((r) => (r.forward ? r.id : `-${r.id}`)),
);
if (setOfRels.size > 1) {
internalError({
type: "Create Relation dialog",
error: `Too many relations between ${selectedTargetType.type} and ${selectedSourceType.type}: ${[...setOfRels].join(",")}`,
});
// let it still fall through to the first
}
}
return candidateRelations[0];
};
Expand Down