Skip to content

feat!: remove deprecated guild create features #1293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat!: remove deprecated guild create features #1293

wants to merge 4 commits into from

Conversation

Snipy7374
Copy link
Collaborator

@Snipy7374 Snipy7374 commented Apr 18, 2025 •
edited
Loading

Summary

Removes Guild.delete, Client.create_guild, Client.guild_builder, Template.create_guild and the GuildBuilder class as well as placeholder payload types from the types/ directory.

This is a BREAKING CHANGE

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@Snipy7374 Snipy7374 added breaking change Includes breaking changes to code/packaging s: needs review Issue/PR is awaiting reviews labels Apr 18, 2025
@Snipy7374 Snipy7374 requested a review from shiftinv April 18, 2025 10:17
@Snipy7374 Snipy7374 mentioned this pull request Aug 23, 2025
Merged
8 tasks
onerandomusername
onerandomusername approved these changes Sep 2, 2025
View reviewed changes
Copy link
Member

@onerandomusername onerandomusername left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a shame.

@shiftinv shiftinv added the do not merge Don't merge. Don't. label Sep 2, 2025
shiftinv
shiftinv requested changes Sep 15, 2025
View reviewed changes
Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a similar fashion, since bots can no longer own guilds, Guild.edit_mfa_level and Guild.edit(owner=) (plus associated http methods and typeddicts) are obsolete now :c
discord/discord-api-docs@a5cb8e5 / discord/discord-api-docs@1d2b9c2

@shiftinv shiftinv removed the do not merge Don't merge. Don't. label Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shiftinv shiftinv shiftinv requested changes

@onerandomusername onerandomusername onerandomusername approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

breaking change Includes breaking changes to code/packaging s: needs review Issue/PR is awaiting reviews

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

remove guild create capabilities

3 participants

@Snipy7374 @shiftinv @onerandomusername