Skip to content

Conversation

onerandomusername
Copy link
Member

Summary

Previously, new modules or files would need to be explicitly added to setup.py

This moves the configuration to pyproject.toml and drops the requirement they must be explicit. At this point, this means the only reason for setup.py is our custom version indicators.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

Previously, new modules or files would need to be explicitly added to setup.py

This moves the configuration to pyproject.toml and drops the requirement they must be explicit
@onerandomusername onerandomusername force-pushed the build/declarative-packages branch from b19f272 to 16b961a Compare September 5, 2025 08:57
@shiftinv
Copy link
Member

shiftinv commented Sep 5, 2025

Wouldn't this change become obsolete with #1323?

@onerandomusername
Copy link
Member Author

it would be obseleted by 1323, but that pull seems like it will take longer to be passed, and I want to move as much as possible out of setup.py.

@shiftinv shiftinv added t: meta Changes to the project itself (CI, configs, etc.) skip news labels Sep 5, 2025
@onerandomusername
Copy link
Member Author

I've also tested locally and this still works with our minimum defined setuptools version of 61.

@shiftinv shiftinv removed the skip news label Sep 5, 2025
Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

root@3fc6fd26ac00:/disnake# wheeldiff dist_master/disnake-2.11.0a0-py3-none-any.whl dist/disnake-2.11.0a0-py3-none-any.whl 
root@3fc6fd26ac00:/disnake# echo $?
0

sure, why not. seems fine to me.

@shiftinv shiftinv enabled auto-merge (squash) September 7, 2025 11:46
@shiftinv shiftinv merged commit bb27273 into master Sep 7, 2025
35 checks passed
@shiftinv shiftinv deleted the build/declarative-packages branch September 7, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t: meta Changes to the project itself (CI, configs, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants