Skip to content

Conversation

onerandomusername
Copy link
Member

Summary

Add a pyproject.toml formatter to stop having so many merge conflicts when changing configurations.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@onerandomusername onerandomusername added the t: meta Changes to the project itself (CI, configs, etc.) label Sep 9, 2025
@github-project-automation github-project-automation bot moved this to Todo in disnake Sep 9, 2025
@onerandomusername onerandomusername changed the title feat: add pyproject-fmt config feat(dev): automatically format the pyproject.toml file with pyprojectfmt Sep 9, 2025
@onerandomusername onerandomusername changed the title feat(dev): automatically format the pyproject.toml file with pyprojectfmt feat(dev): automatically format the pyproject.toml file with pyproject-fmt Sep 9, 2025
[tool.ruff.lint.per-file-ignores]
"disnake/__main__.py" = ["T201"] # print statements are okay in our simple cli
"disnake/i18n.py" = [
lint.per-file-ignores."disnake/**.py" = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing the separate tables makes this much more difficult to understand :/

Copy link
Member Author

@onerandomusername onerandomusername Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's unable to be turned off, unfortunately. I still think the benefits outweigh the negatives.

pyproject.toml Outdated
"subprocess".msg = "Consider possible security implications associated with the subprocess module." # replaces S404
[tool.pytest.ini_options]
minversion = "8.2"
pythonpath = "." # legacy configuration, new pytest versions don't add the rootdir to path
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this github's rendering or this comment really wanna leave the file

@onerandomusername onerandomusername marked this pull request as draft September 16, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news t: meta Changes to the project itself (CI, configs, etc.)

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

3 participants