Skip to content

Conversation

onerandomusername
Copy link
Member

@onerandomusername onerandomusername commented Sep 20, 2025

Summary

drops support for python 3.8

In addition, updates all of the typehints.

This pull should be merged with a merge or rebase strategy, to allow for us to ignore only the typehint update in .git-blame-ignore-revs. We should not be ignoring the min bump.

^ These typehint changes have been moved to #1396

Dependencies will be bumped separately.

There is a pull that updates typing within the documentation, see #1395. Do note that pull is not breaking and does not require this pull.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm run nox -s lint
    • I have type-checked the code by running pdm run nox -s pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@onerandomusername onerandomusername added this to the disnake v2.12 milestone Sep 20, 2025
@github-project-automation github-project-automation bot moved this to Todo in disnake Sep 20, 2025
Base automatically changed from feat/use-uv-v2 to master September 20, 2025 20:19
Copy link

read-the-docs-community bot commented Sep 20, 2025

Documentation build overview

📚 disnake | 🛠️ Build #29723114 | 📁 Comparing 051273b against latest (731eda1)


🔍 Preview build

Show files changed (49 files in total): 📝 49 modified | ➕ 0 added | ➖ 0 deleted
File Status
index.html 📝 modified
intro.html 📝 modified
whats_new.html 📝 modified
api/abc.html 📝 modified
api/activities.html 📝 modified
api/app_commands.html 📝 modified
api/app_info.html 📝 modified
api/audit_logs.html 📝 modified
api/automod.html 📝 modified
api/channels.html 📝 modified
api/clients.html 📝 modified
api/components.html 📝 modified
api/emoji.html 📝 modified
api/entitlements.html 📝 modified
api/events.html 📝 modified
api/exceptions.html 📝 modified
api/guild_scheduled_events.html 📝 modified
api/guilds.html 📝 modified
api/integrations.html 📝 modified
api/interactions.html 📝 modified
api/invites.html 📝 modified
api/localization.html 📝 modified
api/members.html 📝 modified
api/messages.html 📝 modified
api/misc.html 📝 modified
api/permissions.html 📝 modified
api/roles.html 📝 modified
api/skus.html 📝 modified
api/soundboard.html 📝 modified
api/stage_instances.html 📝 modified
api/stickers.html 📝 modified
api/subscriptions.html 📝 modified
api/ui.html 📝 modified
api/users.html 📝 modified
api/utilities.html 📝 modified
api/voice.html 📝 modified
api/webhooks.html 📝 modified
api/widgets.html 📝 modified
ext/tasks/index.html 📝 modified
ext/commands/api/app_commands.html 📝 modified
ext/commands/api/bots.html 📝 modified
ext/commands/api/checks.html 📝 modified
ext/commands/api/cogs.html 📝 modified
ext/commands/api/context.html 📝 modified
ext/commands/api/converters.html 📝 modified
ext/commands/api/exceptions.html 📝 modified
ext/commands/api/help_commands.html 📝 modified
ext/commands/api/misc.html 📝 modified
ext/commands/api/prefix_commands.html 📝 modified

@onerandomusername onerandomusername force-pushed the feat/drop-py38 branch 3 times, most recently from c2526d8 to 2544e0e Compare September 20, 2025 20:56
@onerandomusername onerandomusername linked an issue Sep 21, 2025 that may be closed by this pull request
@onerandomusername onerandomusername marked this pull request as ready for review September 21, 2025 06:53
@onerandomusername onerandomusername requested a review from a team as a code owner September 21, 2025 06:53
@shiftinv shiftinv added breaking change Includes breaking changes to code/packaging t: refactor/typing/lint Refactors, typing changes and/or linting changes labels Sep 21, 2025
@shiftinv
Copy link
Member

A couple things:

  • If it's not too much trouble, could you move the annotation changes to another PR? To keep this one limited to actual runtime differences and metadata/CI changes. Would be cool c:
  • While it's technically still got ~5 weeks until EOL, we might as well drop 3.9 here too, and avoid having to do all the steps twice. The next release containing this PR won't come out within that time frame, anyhow.

@onerandomusername
Copy link
Member Author

Done @shiftinv

@onerandomusername
Copy link
Member Author

@shiftinv this is ready for review, if you could give it a lookover. I want to drop python 3.8 asap.

@onerandomusername onerandomusername self-assigned this Sep 24, 2025
@shiftinv
Copy link
Member

One more mention of 3.8 I could find:

disnake/noxfile.py

Lines 2 to 3 in a7a87c1

# /// script
# requires-python = ">=3.8"

other than that, lgtm c:

@github-project-automation github-project-automation bot moved this from Todo to Needs Merge in disnake Sep 25, 2025
@shiftinv shiftinv enabled auto-merge (squash) September 25, 2025 17:34
@shiftinv shiftinv merged commit 08562f8 into master Sep 25, 2025
33 checks passed
@shiftinv shiftinv deleted the feat/drop-py38 branch September 25, 2025 17:36
@github-project-automation github-project-automation bot moved this from Needs Merge to Done in disnake Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Includes breaking changes to code/packaging t: refactor/typing/lint Refactors, typing changes and/or linting changes

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

drop support for unsupported python versions

2 participants