-
Notifications
You must be signed in to change notification settings - Fork 144
feat!: drop python 3.8 support #1394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c2526d8
to
2544e0e
Compare
2544e0e
to
974b84d
Compare
A couple things:
|
Done @shiftinv |
@shiftinv this is ready for review, if you could give it a lookover. I want to drop python 3.8 asap. |
One more mention of 3.8 I could find: Lines 2 to 3 in a7a87c1
other than that, lgtm c: |
shiftinv
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
Includes breaking changes to code/packaging
t: refactor/typing/lint
Refactors, typing changes and/or linting changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
drops support for python 3.8
In addition, updates all of the typehints.This pull should be merged with a merge or rebase strategy, to allow for us to ignore only the typehint update in .git-blame-ignore-revs. We should not be ignoring the min bump.^ These typehint changes have been moved to #1396
Dependencies will be bumped separately.
There is a pull that updates typing within the documentation, see #1395. Do note that pull is not breaking and does not require this pull.
Checklist
pdm run nox -s lint
pdm run nox -s pyright